From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Alex_Gagniuc@dellteam.com
Cc: mr.nuke.me@gmail.com, bhelgaas@google.com, Austin.Bolen@dell.com,
keith.busch@intel.com, Shyam.Iyer@dell.com, lukas@wunner.de,
okaya@codeaurora.org, rafael.j.wysocki@intel.com,
poza@codeaurora.org, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification
Date: Thu, 29 Nov 2018 21:30:12 +0200 [thread overview]
Message-ID: <20181129193012.GE3078@lahna.fi.intel.com> (raw)
In-Reply-To: <9f76adf7315842cb82375eeaad0a0563@ausx13mps321.AMER.DELL.COM>
On Thu, Nov 29, 2018 at 07:00:58PM +0000, Alex_Gagniuc@Dellteam.com wrote:
> >> + if (link_status & PCI_EXP_LNKSTA_LBMS) {
> >> + if (pdev->subordinate && pdev->subordinate->self)
> >> + endpoint = pdev->subordinate->self;
> >
> > Hmm, I thought pdev->subordinate->self == pdev, no?
>
> That makes no sense, but I think you're right. I'm trying to get to the
> other end of the PCIe link. Is there a simple way to do that? (other
> than convoluted logic that all leads to the same mistake)
AFAIK you should be able to find the other end by looking at the
pdev->subordinate->devices list. Not sure if there is a simpler way,
though.
next prev parent reply other threads:[~2018-11-29 19:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-29 0:08 [PATCH] PCI: pciehp: Report degraded links via link bandwidth notification Alexandru Gagniuc
2018-11-29 16:06 ` Mika Westerberg
2018-11-29 19:00 ` Alex_Gagniuc
2018-11-29 19:30 ` Mika Westerberg [this message]
2018-11-29 17:35 ` Bjorn Helgaas
2018-11-29 18:57 ` Alex_Gagniuc
2018-11-29 19:13 ` Lukas Wunner
2018-11-29 23:04 ` Bjorn Helgaas
2018-11-29 23:24 ` Alex_Gagniuc
2018-12-07 18:20 ` [PATCH v2] " Alexandru Gagniuc
2018-12-27 19:33 ` Alex G.
2019-02-25 2:28 ` Lukas Wunner
2019-02-27 20:21 ` Alex_Gagniuc
2019-02-28 6:43 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181129193012.GE3078@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Alex_Gagniuc@dellteam.com \
--cc=Austin.Bolen@dell.com \
--cc=Shyam.Iyer@dell.com \
--cc=bhelgaas@google.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mr.nuke.me@gmail.com \
--cc=okaya@codeaurora.org \
--cc=poza@codeaurora.org \
--cc=rafael.j.wysocki@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox