From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
Dave Emett <david.emett@broadcom.com>,
Thomas Spurden <thomas.spurden@broadcom.com>,
Eric Anholt <eric@anholt.net>
Subject: [PATCH 1/6] drm/v3d: Document cache flushing ABI.
Date: Fri, 30 Nov 2018 16:57:54 -0800 [thread overview]
Message-ID: <20181201005759.28093-1-eric@anholt.net> (raw)
Right now, userspace doesn't do any L2T writes, but we should lay out
our expectations for how it works.
Signed-off-by: Eric Anholt <eric@anholt.net>
---
include/uapi/drm/v3d_drm.h | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/include/uapi/drm/v3d_drm.h b/include/uapi/drm/v3d_drm.h
index 35c7d813c66e..95b8f8e82ea5 100644
--- a/include/uapi/drm/v3d_drm.h
+++ b/include/uapi/drm/v3d_drm.h
@@ -52,6 +52,13 @@ extern "C" {
*
* This asks the kernel to have the GPU execute an optional binner
* command list, and a render command list.
+ *
+ * The caches (L1T, slice, and L2T) will be flushed before the job
+ * executes. The TLB writes are guaranteed to have been flushed by
+ * the time the render done IRQ happens, which is the trigger for
+ * out_sync. Any dirtying of cachelines by the job (only possible
+ * using TMU writes) must be flushed by the caller using the CL's
+ * cache flush commands.
*/
struct drm_v3d_submit_cl {
/* Pointer to the binner command list.
--
2.20.0.rc1
next reply other threads:[~2018-12-01 0:58 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 0:57 Eric Anholt [this message]
2018-12-01 0:57 ` [PATCH 2/6] drm/v3d: Drop unused v3d_flush_caches() Eric Anholt
2018-12-03 17:44 ` Dave Emett
2018-12-01 0:57 ` [PATCH 3/6] drm/v3d: Don't bother flushing L1TD at job start Eric Anholt
2018-12-03 17:36 ` Dave Emett
2018-12-01 0:57 ` [PATCH 4/6] drm/v3d: Drop the wait for L2T flush to complete Eric Anholt
2018-12-03 17:59 ` Dave Emett
2018-12-01 0:57 ` [PATCH 5/6] drm/v3d: Add more tracepoints for V3D GPU rendering Eric Anholt
2018-12-03 17:41 ` Dave Emett
2018-12-01 0:57 ` [PATCH 6/6] drm/v3d: Add missing fence timeline name for TFU Eric Anholt
2018-12-03 18:03 ` Dave Emett
2018-12-03 17:22 ` [PATCH 1/6] drm/v3d: Document cache flushing ABI Dave Emett
2018-12-03 17:28 ` Dave Emett
2018-12-03 20:39 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201005759.28093-1-eric@anholt.net \
--to=eric@anholt.net \
--cc=david.emett@broadcom.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.spurden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox