public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: dri-devel@lists.freedesktop.org
Cc: linux-kernel@vger.kernel.org,
	Dave Emett <david.emett@broadcom.com>,
	Thomas Spurden <thomas.spurden@broadcom.com>,
	Eric Anholt <eric@anholt.net>
Subject: [PATCH 4/6] drm/v3d: Drop the wait for L2T flush to complete.
Date: Fri, 30 Nov 2018 16:57:57 -0800	[thread overview]
Message-ID: <20181201005759.28093-4-eric@anholt.net> (raw)
In-Reply-To: <20181201005759.28093-1-eric@anholt.net>

According to Dave, once you've started an L2T flush, all L2T accesses
will be blocked until the flush completes.  This fixes a consistent
3-4ms stall between the ioctl and running the job, and 3DMMES Taiji
goes from 27fps to 110fps.

Signed-off-by: Eric Anholt <eric@anholt.net>
Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom V3D V3.x+")
---
 drivers/gpu/drm/v3d/v3d_gem.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/gpu/drm/v3d/v3d_gem.c b/drivers/gpu/drm/v3d/v3d_gem.c
index cc4d025b01e0..0bd6892e3044 100644
--- a/drivers/gpu/drm/v3d/v3d_gem.c
+++ b/drivers/gpu/drm/v3d/v3d_gem.c
@@ -146,10 +146,6 @@ v3d_flush_l2t(struct v3d_dev *v3d, int core)
 	V3D_CORE_WRITE(core, V3D_CTL_L2TCACTL,
 		       V3D_L2TCACTL_L2TFLS |
 		       V3D_SET_FIELD(V3D_L2TCACTL_FLM_FLUSH, V3D_L2TCACTL_FLM));
-	if (wait_for(!(V3D_CORE_READ(core, V3D_CTL_L2TCACTL) &
-		       V3D_L2TCACTL_L2TFLS), 100)) {
-		DRM_ERROR("Timeout waiting for L2T flush\n");
-	}
 }
 
 /* Invalidates the slice caches.  These are read-only caches. */
-- 
2.20.0.rc1


  parent reply	other threads:[~2018-12-01  0:58 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-01  0:57 [PATCH 1/6] drm/v3d: Document cache flushing ABI Eric Anholt
2018-12-01  0:57 ` [PATCH 2/6] drm/v3d: Drop unused v3d_flush_caches() Eric Anholt
2018-12-03 17:44   ` Dave Emett
2018-12-01  0:57 ` [PATCH 3/6] drm/v3d: Don't bother flushing L1TD at job start Eric Anholt
2018-12-03 17:36   ` Dave Emett
2018-12-01  0:57 ` Eric Anholt [this message]
2018-12-03 17:59   ` [PATCH 4/6] drm/v3d: Drop the wait for L2T flush to complete Dave Emett
2018-12-01  0:57 ` [PATCH 5/6] drm/v3d: Add more tracepoints for V3D GPU rendering Eric Anholt
2018-12-03 17:41   ` Dave Emett
2018-12-01  0:57 ` [PATCH 6/6] drm/v3d: Add missing fence timeline name for TFU Eric Anholt
2018-12-03 18:03   ` Dave Emett
2018-12-03 17:22 ` [PATCH 1/6] drm/v3d: Document cache flushing ABI Dave Emett
2018-12-03 17:28   ` Dave Emett
2018-12-03 20:39     ` Eric Anholt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181201005759.28093-4-eric@anholt.net \
    --to=eric@anholt.net \
    --cc=david.emett@broadcom.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thomas.spurden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox