* [PATCH] HSI: omap_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro
@ 2018-12-01 2:33 Yangtao Li
2018-12-05 15:39 ` Sebastian Reichel
0 siblings, 1 reply; 2+ messages in thread
From: Yangtao Li @ 2018-12-01 2:33 UTC (permalink / raw)
To: sre, gregkh, rdunlap; +Cc: linux-kernel, Yangtao Li
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/hsi/controllers/omap_ssi_core.c | 29 ++++---------------------
drivers/hsi/controllers/omap_ssi_port.c | 14 ++----------
2 files changed, 6 insertions(+), 37 deletions(-)
diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
index 41a09f506803..a2a35319f7a5 100644
--- a/drivers/hsi/controllers/omap_ssi_core.c
+++ b/drivers/hsi/controllers/omap_ssi_core.c
@@ -48,7 +48,7 @@
static DEFINE_IDA(platform_omap_ssi_ida);
#ifdef CONFIG_DEBUG_FS
-static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused)
+static int ssi_regs_show(struct seq_file *m, void *p __maybe_unused)
{
struct hsi_controller *ssi = m->private;
struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
@@ -63,7 +63,7 @@ static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused)
return 0;
}
-static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused)
+static int ssi_gdd_regs_show(struct seq_file *m, void *p __maybe_unused)
{
struct hsi_controller *ssi = m->private;
struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
@@ -117,29 +117,8 @@ static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused)
return 0;
}
-static int ssi_regs_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ssi_debug_show, inode->i_private);
-}
-
-static int ssi_gdd_regs_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ssi_debug_gdd_show, inode->i_private);
-}
-
-static const struct file_operations ssi_regs_fops = {
- .open = ssi_regs_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
-
-static const struct file_operations ssi_gdd_regs_fops = {
- .open = ssi_gdd_regs_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ssi_regs);
+DEFINE_SHOW_ATTRIBUTE(ssi_gdd_regs);
static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
{
diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
index 2ada82d2ec8c..b2b3989ccfd2 100644
--- a/drivers/hsi/controllers/omap_ssi_port.c
+++ b/drivers/hsi/controllers/omap_ssi_port.c
@@ -57,7 +57,7 @@ static void ssi_debug_remove_port(struct hsi_port *port)
debugfs_remove_recursive(omap_port->dir);
}
-static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
+static int ssi_port_regs_show(struct seq_file *m, void *p __maybe_unused)
{
struct hsi_port *port = m->private;
struct omap_ssi_port *omap_port = hsi_port_drvdata(port);
@@ -132,17 +132,7 @@ static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
return 0;
}
-static int ssi_port_regs_open(struct inode *inode, struct file *file)
-{
- return single_open(file, ssi_debug_port_show, inode->i_private);
-}
-
-static const struct file_operations ssi_port_regs_fops = {
- .open = ssi_port_regs_open,
- .read = seq_read,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ssi_port_regs);
static int ssi_div_get(void *data, u64 *val)
{
--
2.17.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HSI: omap_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro
2018-12-01 2:33 [PATCH] HSI: omap_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
@ 2018-12-05 15:39 ` Sebastian Reichel
0 siblings, 0 replies; 2+ messages in thread
From: Sebastian Reichel @ 2018-12-05 15:39 UTC (permalink / raw)
To: Yangtao Li; +Cc: gregkh, rdunlap, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 3644 bytes --]
Hi,
On Fri, Nov 30, 2018 at 09:33:55PM -0500, Yangtao Li wrote:
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
Thanks, nice cleanup! Queued to hsi-next.
-- Sebastian
> drivers/hsi/controllers/omap_ssi_core.c | 29 ++++---------------------
> drivers/hsi/controllers/omap_ssi_port.c | 14 ++----------
> 2 files changed, 6 insertions(+), 37 deletions(-)
>
> diff --git a/drivers/hsi/controllers/omap_ssi_core.c b/drivers/hsi/controllers/omap_ssi_core.c
> index 41a09f506803..a2a35319f7a5 100644
> --- a/drivers/hsi/controllers/omap_ssi_core.c
> +++ b/drivers/hsi/controllers/omap_ssi_core.c
> @@ -48,7 +48,7 @@
> static DEFINE_IDA(platform_omap_ssi_ida);
>
> #ifdef CONFIG_DEBUG_FS
> -static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused)
> +static int ssi_regs_show(struct seq_file *m, void *p __maybe_unused)
> {
> struct hsi_controller *ssi = m->private;
> struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
> @@ -63,7 +63,7 @@ static int ssi_debug_show(struct seq_file *m, void *p __maybe_unused)
> return 0;
> }
>
> -static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused)
> +static int ssi_gdd_regs_show(struct seq_file *m, void *p __maybe_unused)
> {
> struct hsi_controller *ssi = m->private;
> struct omap_ssi_controller *omap_ssi = hsi_controller_drvdata(ssi);
> @@ -117,29 +117,8 @@ static int ssi_debug_gdd_show(struct seq_file *m, void *p __maybe_unused)
> return 0;
> }
>
> -static int ssi_regs_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, ssi_debug_show, inode->i_private);
> -}
> -
> -static int ssi_gdd_regs_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, ssi_debug_gdd_show, inode->i_private);
> -}
> -
> -static const struct file_operations ssi_regs_fops = {
> - .open = ssi_regs_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> -
> -static const struct file_operations ssi_gdd_regs_fops = {
> - .open = ssi_gdd_regs_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(ssi_regs);
> +DEFINE_SHOW_ATTRIBUTE(ssi_gdd_regs);
>
> static int ssi_debug_add_ctrl(struct hsi_controller *ssi)
> {
> diff --git a/drivers/hsi/controllers/omap_ssi_port.c b/drivers/hsi/controllers/omap_ssi_port.c
> index 2ada82d2ec8c..b2b3989ccfd2 100644
> --- a/drivers/hsi/controllers/omap_ssi_port.c
> +++ b/drivers/hsi/controllers/omap_ssi_port.c
> @@ -57,7 +57,7 @@ static void ssi_debug_remove_port(struct hsi_port *port)
> debugfs_remove_recursive(omap_port->dir);
> }
>
> -static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
> +static int ssi_port_regs_show(struct seq_file *m, void *p __maybe_unused)
> {
> struct hsi_port *port = m->private;
> struct omap_ssi_port *omap_port = hsi_port_drvdata(port);
> @@ -132,17 +132,7 @@ static int ssi_debug_port_show(struct seq_file *m, void *p __maybe_unused)
> return 0;
> }
>
> -static int ssi_port_regs_open(struct inode *inode, struct file *file)
> -{
> - return single_open(file, ssi_debug_port_show, inode->i_private);
> -}
> -
> -static const struct file_operations ssi_port_regs_fops = {
> - .open = ssi_port_regs_open,
> - .read = seq_read,
> - .llseek = seq_lseek,
> - .release = single_release,
> -};
> +DEFINE_SHOW_ATTRIBUTE(ssi_port_regs);
>
> static int ssi_div_get(void *data, u64 *val)
> {
> --
> 2.17.0
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-05 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-01 2:33 [PATCH] HSI: omap_ssi: Change to use DEFINE_SHOW_ATTRIBUTE macro Yangtao Li
2018-12-05 15:39 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox