From: Stephen Hemminger <stephen@networkplumber.org>
To: Qian Cai <cai@gmx.us>
Cc: davem@davemloft.net, yisen.zhuang@huawei.com,
salil.mehta@huawei.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/core: tidy up an error message
Date: Sat, 1 Dec 2018 09:17:22 -0800 [thread overview]
Message-ID: <20181201091722.6c9a8f06@xeon-e3> (raw)
In-Reply-To: <20181201045153.4035-1-cai@gmx.us>
On Fri, 30 Nov 2018 23:51:53 -0500
Qian Cai <cai@gmx.us> wrote:
> + weight,
> + !strchr(dev->name, '%') ? dev->name : "unknown"
Agree with Joe, use netdev_err_once or use netdev_name().
prev parent reply other threads:[~2018-12-01 17:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 4:51 [PATCH] net/core: tidy up an error message Qian Cai
2018-12-01 14:43 ` Joe Perches
2018-12-01 17:17 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181201091722.6c9a8f06@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=cai@gmx.us \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox