From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E3E9C04EB9 for ; Sat, 1 Dec 2018 12:59:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CB77F20834 for ; Sat, 1 Dec 2018 12:59:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB77F20834 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ucw.cz Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726789AbeLBAMQ (ORCPT ); Sat, 1 Dec 2018 19:12:16 -0500 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:53386 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726708AbeLBAMP (ORCPT ); Sat, 1 Dec 2018 19:12:15 -0500 Received: by atrey.karlin.mff.cuni.cz (Postfix, from userid 512) id F0FB680A44; Sat, 1 Dec 2018 13:59:41 +0100 (CET) Date: Sat, 1 Dec 2018 13:59:44 +0100 From: Pavel Machek To: Lubomir Rintel Cc: arm@kernel.org, Olof Johansson , Arnd Bergmann , Eric Miao , Haojian Zhuang , Russell King , Robert Jarzmik , James Cameron , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 12/20] irqchip/mmp: do not use of_address_to_resource() to get mux regs Message-ID: <20181201125944.GA31631@amd> References: <20181128175324.163202-1-lkundrak@v3.sk> <20181128175324.163202-13-lkundrak@v3.sk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="YZ5djTAD1cGYuMQK" Content-Disposition: inline In-Reply-To: <20181128175324.163202-13-lkundrak@v3.sk> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --YZ5djTAD1cGYuMQK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed 2018-11-28 18:53:16, Lubomir Rintel wrote: > The "regs" property of the "mrvl,mmp2-mux-intc" devices are silly. They > are offsets from intc's base, not addresses on the parent bus. At this > point it probably can't be fixed. >=20 > On an OLPC XO-1.75 machine, the muxes are children of the intc, not the > axi bus, and thus of_address_to_resource() won't work. We should treat > the values as mere integers as opposed to bus addresses. >=20 > Signed-off-by: Lubomir Rintel Comment in the code and big warning in the dts description would be nice. Otherwise... Acked-by: Pavel Machek --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --YZ5djTAD1cGYuMQK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlwChcAACgkQMOfwapXb+vIGRwCgkt68puXV/4p6zD7n8y890wZg 8wAAmgKzZcVWDKewWnNEyBCLolJhBNC4 =QRyg -----END PGP SIGNATURE----- --YZ5djTAD1cGYuMQK--