From: Peter Zijlstra <peterz@infradead.org>
To: "Paul E. McKenney" <paulmck@linux.ibm.com>
Cc: Wen Yang <wen.yang99@zte.com.cn>,
Davidlohr Bueso <dave@stgolabs.net>,
Josh Triplett <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn,
mingo@redhat.com, will.deacon@arm.com, Julia.Lawall@lip6.fr
Subject: Re: [PATCH] locktorture: Fix assignment of boolean variables
Date: Mon, 3 Dec 2018 09:46:05 +0100 [thread overview]
Message-ID: <20181203084605.GC11650@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181203083500.GH11614@hirez.programming.kicks-ass.net>
On Mon, Dec 03, 2018 at 09:35:00AM +0100, Peter Zijlstra wrote:
> On Sat, Dec 01, 2018 at 12:37:01PM -0800, Paul E. McKenney wrote:
> > On Sat, Dec 01, 2018 at 04:31:49PM +0800, Wen Yang wrote:
> > > Fix the following warnings reported by coccinelle:
> > >
> > > kernel/locking/locktorture.c:703:6-10: WARNING: Assignment of bool to 0/1
Not to mention that WARN is gramatically incorrect. We're not assigning
'bool' to 0/1 but the other way around.
What crap..
> So I strongly disagree with this. Anybody that has trouble with 0/1 vs
> false/true needs to stay the heck away from C.
>
> I would suggest we delete that stupid coccinelle scripts that generates
> these pointless warns.
next prev parent reply other threads:[~2018-12-03 8:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-01 8:31 [PATCH] locktorture: Fix assignment of boolean variables Wen Yang
2018-12-01 20:37 ` Paul E. McKenney
2018-12-03 8:35 ` Peter Zijlstra
2018-12-03 8:46 ` Peter Zijlstra [this message]
2018-12-03 9:20 ` Julia Lawall
2018-12-03 10:50 ` Peter Zijlstra
2018-12-03 14:07 ` Julia Lawall
2018-12-03 8:52 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203084605.GC11650@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Julia.Lawall@lip6.fr \
--cc=dave@stgolabs.net \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paulmck@linux.ibm.com \
--cc=wen.yang99@zte.com.cn \
--cc=will.deacon@arm.com \
--cc=zhong.weidong@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox