From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 255F6C04EB9 for ; Mon, 3 Dec 2018 10:35:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E58D82082F for ; Mon, 3 Dec 2018 10:35:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E58D82082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726170AbeLCKfj (ORCPT ); Mon, 3 Dec 2018 05:35:39 -0500 Received: from mail.bootlin.com ([62.4.15.54]:57458 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725947AbeLCKfj (ORCPT ); Mon, 3 Dec 2018 05:35:39 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 8831520CFA; Mon, 3 Dec 2018 11:35:09 +0100 (CET) Received: from bbrezillon (91-160-177-164.subs.proxad.net [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id 471B0207B0; Mon, 3 Dec 2018 11:34:59 +0100 (CET) Date: Mon, 3 Dec 2018 11:34:59 +0100 From: Boris Brezillon To: Huijin Park , Boris Brezillon Cc: linux-kernel@vger.kernel.org, Marek Vasut , Geert Uytterhoeven , linux-mtd@lists.infradead.org, bbanghj.park@gmail.com Subject: Re: [v3] mtd: spi-nor: cast to u64 to avoid uint overflows Message-ID: <20181203113459.05f29284@bbrezillon> In-Reply-To: <20181203075154.28637-1-boris.brezillon@bootlin.com> References: <1543392134-1443-1-git-send-email-huijin.park@samsung.com> <20181203075154.28637-1-boris.brezillon@bootlin.com> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 3 Dec 2018 08:51:54 +0100 Boris Brezillon wrote: > On Wed, 2018-11-28 at 08:02:14 UTC, Huijin Park wrote: > > From: "huijin.park" > > > > The "params->size" is defined as "u64". > > And "info->sector_size" and "info->n_sectors" are defined as > > unsigned int and u16. > > Thus, u64 data might have strange data(loss data) if the result > > overflows an unsigned int. > > This patch casts "info->sector_size" to an u64. > > > > Signed-off-by: huijin.park > > Reviewed-by: Geert Uytterhoeven > > Applied to http://git.infradead.org/linux-mtd.git mtd/next, thanks. Oops, should I been queued to spi-nor/next. I dropped the patch and will soon push it to spi-nor/next.