From: Olof Johansson <olof@lixom.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Lubomir Rintel <lkundrak@v3.sk>, arm-soc <arm@kernel.org>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
quozl@laptop.org,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ARM: mmp/mmp2: fix cpu_is_mmp2() on mmp2-dt
Date: Mon, 3 Dec 2018 12:39:41 -0800 [thread overview]
Message-ID: <20181203203941.5xwlklfirraf7svm@localhost> (raw)
In-Reply-To: <CAK8P3a3rEuccqhAgpNR6tP1g826m8o-mWtM1vNmGMb_-H8YMoA@mail.gmail.com>
On Sun, Dec 02, 2018 at 04:53:07PM +0100, Arnd Bergmann wrote:
> On Sun, Dec 2, 2018 at 12:12 PM Lubomir Rintel <lkundrak@v3.sk> wrote:
> >
> > cpu_is_mmp2() was equivalent to cpu_is_pj4(), wouldn't be correct for
> > multiplatform kernels. Fix it by also considering mmp_chip_id, as is
> > done for cpu_is_pxa168() and cpu_is_pxa910() above.
> >
> > Moreover, it is only available with CONFIG_CPU_MMP2 and thus doesn't work
> > on DT-based MMP2 machines. Enable it on CONFIG_MACH_MMP2_DT too.
> >
> > Note: CONFIG_CPU_MMP2 is only used for machines that use board files
> > instead of DT. It should perhaps be renamed. I'm not doing it now, because
> > I don't have a better idea.
> >
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I'd suggest adding
>
> Cc: stable@vger.kernel.org
>
> since this fixes bugs on other platforms when CONFIG_MMP2 is enabled
> in a multiplatform kernel.
Applied to fixes with those tags. Thanks!
-Olof
prev parent reply other threads:[~2018-12-03 20:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 11:12 [PATCH] ARM: mmp/mmp2: fix cpu_is_mmp2() on mmp2-dt Lubomir Rintel
2018-12-02 15:53 ` Arnd Bergmann
2018-12-03 20:39 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181203203941.5xwlklfirraf7svm@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
--cc=pavel@ucw.cz \
--cc=quozl@laptop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox