From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Petr Mladek <pmladek@suse.com>,
Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] printk: don't unconditionally shortcut print_time()
Date: Tue, 4 Dec 2018 11:56:14 +0900 [thread overview]
Message-ID: <20181204025614.GC7580@jagdpanzerIV> (raw)
In-Reply-To: <1c1de4f8-f08e-37e5-2438-47ab985d476e@i-love.sakura.ne.jp>
On (12/02/18 14:02), Tetsuo Handa wrote:
>
> @@ -1541,11 +1545,13 @@ int do_syslog(int type, char __user *buf, int len, int source)
> } else {
> u64 seq = syslog_seq;
> u32 idx = syslog_idx;
> + bool f = syslog_partial ? syslog_time : printk_time;
^^^^^^
> while (seq < log_next_seq) {
> struct printk_log *msg = log_from_idx(idx);
>
> - error += msg_print_text(msg, true, NULL, 0);
> + error += msg_print_text(msg, true, f, NULL, 0);
^^^^
> + f = printk_time;
^^^
> idx = log_next(idx);
> seq++;
Can we please have something better than 'f'?
-ss
next prev parent reply other threads:[~2018-12-04 2:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-24 10:50 [PATCH] printk: don't unconditionally shortcut print_time() Tetsuo Handa
2018-11-24 14:28 ` [PATCH] printk: deduplicate print_prefix() calls Tetsuo Handa
2018-11-26 7:56 ` Sergey Senozhatsky
2018-11-26 10:21 ` Tetsuo Handa
2018-11-29 14:35 ` Petr Mladek
2018-11-29 14:19 ` [PATCH] printk: don't unconditionally shortcut print_time() Petr Mladek
2018-11-30 2:26 ` Tetsuo Handa
2018-11-30 12:30 ` Petr Mladek
2018-11-30 14:33 ` Tetsuo Handa
2018-12-01 11:30 ` Tetsuo Handa
2018-12-02 5:02 ` Tetsuo Handa
2018-12-03 13:16 ` Petr Mladek
2018-12-04 2:56 ` Sergey Senozhatsky [this message]
2018-12-04 10:06 ` Tetsuo Handa
2018-12-04 10:59 ` Sergey Senozhatsky
2018-12-03 14:14 ` Petr Mladek
2018-12-03 15:00 ` Tetsuo Handa
2018-11-30 4:24 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181204025614.GC7580@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox