Linux-next: Build failed

Linux-next: Build failed

[Naresh Kamboju]

FYI,

The Linux -next build failed due to below warnings/errors.

include/asm-generic/bitops/atomic.h: In function 'set_bit':
include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
of function 'atomic_long_or'; did you mean '__atomic_load_n'?
[-Werror=implicit-function-declaration]
  atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
  ^~~~~~~~~~~~~~
  __atomic_load_n
include/asm-generic/bitops/atomic.h: In function 'clear_bit':
include/asm-generic/bitops/atomic.h:23:2: error: implicit declaration
of function 'atomic_long_andnot'; did you mean
'__atomic_test_and_set'? [-Werror=implicit-function-declaration]
  atomic_long_andnot(BIT_MASK(nr), (atomic_long_t *)p);
  ^~~~~~~~~~~~~~~~~~
  __atomic_test_and_set
include/asm-generic/bitops/atomic.h: In function 'change_bit':
include/asm-generic/bitops/atomic.h:29:2: error: implicit declaration
of function 'atomic_long_xor'; did you mean '__atomic_load_n'?
[-Werror=implicit-function-declaration]
  atomic_long_xor(BIT_MASK(nr), (atomic_long_t *)p);
  ^~~~~~~~~~~~~~~
  __atomic_load_n
include/asm-generic/bitops/atomic.h: In function 'test_and_set_bit':
include/asm-generic/bitops/atomic.h:41:8: error: implicit declaration
of function 'atomic_long_fetch_or'; did you mean
'__atomic_and_fetch_1'? [-Werror=implicit-function-declaration]
  old = atomic_long_fetch_or(mask, (atomic_long_t *)p);
        ^~~~~~~~~~~~~~~~~~~~
        __atomic_and_fetch_1
include/asm-generic/bitops/atomic.h: In function 'test_and_clear_bit':
include/asm-generic/bitops/atomic.h:54:8: error: implicit declaration
of function 'atomic_long_fetch_andnot'; did you mean
'arch_atomic64_fetch_andnot'? [-Werror=implicit-function-declaration]
  old = atomic_long_fetch_andnot(mask, (atomic_long_t *)p);
        ^~~~~~~~~~~~~~~~~~~~~~~~
        arch_atomic64_fetch_andnot
include/asm-generic/bitops/atomic.h: In function 'test_and_change_bit':
include/asm-generic/bitops/atomic.h:64:8: error: implicit declaration
of function 'atomic_long_fetch_xor'; did you mean
'__atomic_fetch_xor'? [-Werror=implicit-function-declaration]
  old = atomic_long_fetch_xor(mask, (atomic_long_t *)p);
        ^~~~~~~~~~~~~~~~~~~~~
        __atomic_fetch_xor

cc1: some warnings being treated as errors

full log details,
https://ci.linaro.org/job/openembedded-lkft-linux-next/DISTRO=rpb,MACHINE=juno,label=docker-stretch-amd64/407/consoleText

Best regards
Naresh Kamboju

Re: Linux-next: Build failed

[Will Deacon]

Hi Naresh,

On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
> FYI,
> 
> The Linux -next build failed due to below warnings/errors.
> 
> include/asm-generic/bitops/atomic.h: In function 'set_bit':
> include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
> of function 'atomic_long_or'; did you mean '__atomic_load_n'?
> [-Werror=implicit-function-declaration]
>   atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
>   ^~~~~~~~~~~~~~
>   __atomic_load_n

Ha, I like that the compiler is trying to get us to use its __atomic
builtins here :)

Anyway, you're seeing this because of this previous error in Mark's script:

.../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found

even though fold is part of coreutils :/

Do you have grep? Maybe the diff below helps.

Will

--->8

diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
index 9d6be538a987..81d5c32039dd 100755
--- a/scripts/atomic/atomic-tbl.sh
+++ b/scripts/atomic/atomic-tbl.sh
@@ -180,7 +180,7 @@ gen_proto_variants()
 #gen_proto(meta, ...)
 gen_proto() {
        local meta="$1"; shift
-       for m in $(echo "${meta}" | fold -w1); do
+       for m in $(echo "${meta}" | grep -o .); do
                gen_proto_variants "${m}" "$@"
        done
 }

Re: Linux-next: Build failed

[Naresh Kamboju]

Hi Will,

On Tue, 4 Dec 2018 at 18:22, Will Deacon <will.deacon@arm.com> wrote:
>
> Hi Naresh,
>
> On Tue, Dec 04, 2018 at 05:56:09PM +0530, Naresh Kamboju wrote:
> > FYI,
> >
> > The Linux -next build failed due to below warnings/errors.
> >
> > include/asm-generic/bitops/atomic.h: In function 'set_bit':
> > include/asm-generic/bitops/atomic.h:17:2: error: implicit declaration
> > of function 'atomic_long_or'; did you mean '__atomic_load_n'?
> > [-Werror=implicit-function-declaration]
> >   atomic_long_or(BIT_MASK(nr), (atomic_long_t *)p);
> >   ^~~~~~~~~~~~~~
> >   __atomic_load_n
>
> Ha, I like that the compiler is trying to get us to use its __atomic
> builtins here :)
>
> Anyway, you're seeing this because of this previous error in Mark's script:
>
> .../scripts/atomic/atomic-tbl.sh: line 183: fold: command not found
>
> even though fold is part of coreutils :/
>
> Do you have grep? Maybe the diff below helps.

Yes. grep is present.
Thanks for the quick patch.

- Naresh

>
> Will
>
> --->8
>
> diff --git a/scripts/atomic/atomic-tbl.sh b/scripts/atomic/atomic-tbl.sh
> index 9d6be538a987..81d5c32039dd 100755
> --- a/scripts/atomic/atomic-tbl.sh
> +++ b/scripts/atomic/atomic-tbl.sh
> @@ -180,7 +180,7 @@ gen_proto_variants()
>  #gen_proto(meta, ...)
>  gen_proto() {
>         local meta="$1"; shift
> -       for m in $(echo "${meta}" | fold -w1); do
> +       for m in $(echo "${meta}" | grep -o .); do
>                 gen_proto_variants "${m}" "$@"
>         done
>  }
>