public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Will Deacon <will.deacon@arm.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
	linux-kernel@vger.kernel.org,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>
Subject: Re: [PATCH v3] perf: tests: Disable breakpoint tests on ARM (32-bit)
Date: Tue, 4 Dec 2018 11:12:55 -0300	[thread overview]
Message-ID: <20181204141255.GC19069@kernel.org> (raw)
In-Reply-To: <20181204140615.GB5837@arm.com>

Em Tue, Dec 04, 2018 at 02:06:16PM +0000, Will Deacon escreveu:
> On Mon, Dec 03, 2018 at 11:11:36AM -0800, Florian Fainelli wrote:
> > breakpoint tests on the ARM 32-bit kernel are broken in several ways.
> > 
> > The breakpoint length requested does not necessarily match whether the
> > function address has the Thumb bit (bit 0) set or not, and this does
> > matter to the ARM kernel hw_breakpoint infrastructure. See [1] for
> > background.
> > 
> > [1]: https://lkml.org/lkml/2018/11/15/205
> > 
> > As Will indicated, the overflow handling would require single-stepping
> > which is not supported at the moment. Just disable those tests for the
> > ARM 32-bit platforms and update the comment above to explain these
> > limitations.
> > 
> > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
> > ---
> > Changes in v3:
> > 
> > - directly incorporate Will's comment, Will can you add your
> >   Signed-off-by?
> 
> Of course:
> 
> Co-developed-by: Will Deacon <will.deacon@arm.com>
> Signed-off-by: Will Deacon <will.deacon@arm.com>

Thanks, added those and applied the patch.

- Arnaldo

  reply	other threads:[~2018-12-04 14:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-03 19:11 [PATCH v3] perf: tests: Disable breakpoint tests on ARM (32-bit) Florian Fainelli
2018-12-04 14:06 ` Will Deacon
2018-12-04 14:12   ` Arnaldo Carvalho de Melo [this message]
2018-12-14 20:39 ` [tip:perf/core] perf tests ARM: Disable breakpoint tests 32-bit tip-bot for Florian Fainelli
2018-12-18 14:06 ` tip-bot for Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181204141255.GC19069@kernel.org \
    --to=acme@kernel.org \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=f.fainelli@gmail.com \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox