From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0027FC04EB9 for ; Wed, 5 Dec 2018 12:28:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C534C2084C for ; Wed, 5 Dec 2018 12:28:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C534C2084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727484AbeLEM2l (ORCPT ); Wed, 5 Dec 2018 07:28:41 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41392 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbeLEM2k (ORCPT ); Wed, 5 Dec 2018 07:28:40 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3676930B7B9F; Wed, 5 Dec 2018 12:28:40 +0000 (UTC) Received: from krava (unknown [10.43.17.30]) by smtp.corp.redhat.com (Postfix) with SMTP id DC0485C57E; Wed, 5 Dec 2018 12:28:38 +0000 (UTC) Date: Wed, 5 Dec 2018 13:28:38 +0100 From: Jiri Olsa To: Andi Kleen Cc: acme@kernel.org, jolsa@kernel.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org, Andi Kleen Subject: Re: [PATCH] perf, tools: Support srccode output Message-ID: <20181205122838.GH2950@krava> References: <20181204001848.24769-1-andi@firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181204001848.24769-1-andi@firstfloor.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.43]); Wed, 05 Dec 2018 12:28:40 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 03, 2018 at 04:18:48PM -0800, Andi Kleen wrote: > From: Andi Kleen > > When looking at PT or brstackinsn traces with perf script > it can be very useful to see the source code. This adds a simple > facility to print them with perf script, if the information > is available through dwarf > > % perf record ... > % perf script -F insn,ip,sym,srccode > ... > > 4004c6 main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004c6 main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004cd main > 5 for (i = 0; i < 10000000; i++) > 4004b3 main > 6 v++; > > % perf record -b ... > % perf script -F insn,ip,sym,srccode,brstackinsn > > ... > main+22: > 0000000000400543 insn: e8 ca ff ff ff # PRED > |18 f1(); > f1: > 0000000000400512 insn: 55 > |10 { > 0000000000400513 insn: 48 89 e5 > 0000000000400516 insn: b8 00 00 00 00 > |11 f2(); > 000000000040051b insn: e8 d6 ff ff ff # PRED > f2: > 00000000004004f6 insn: 55 > |5 { > 00000000004004f7 insn: 48 89 e5 > 00000000004004fa insn: 8b 05 2c 0b 20 00 > |6 c = a / b; > 0000000000400500 insn: 8b 0d 2a 0b 20 00 > 0000000000400506 insn: 99 > 0000000000400507 insn: f7 f9 > 0000000000400509 insn: 89 05 29 0b 20 00 > 000000000040050f insn: 90 > |7 } > 0000000000400510 insn: 5d > 0000000000400511 insn: c3 # PRED > f1+14: > 0000000000400520 insn: b8 00 00 00 00 > |12 f2(); > 0000000000400525 insn: e8 cc ff ff ff # PRED > f2: > 00000000004004f6 insn: 55 > |5 { > 00000000004004f7 insn: 48 89 e5 > 00000000004004fa insn: 8b 05 2c 0b 20 00 > |6 c = a / b; > > Not supported for callchains currently, would need some > layout changes there. nice, works nicely, especialy with --xed Acked-by: Jiri Olsa I need to check, but is there a way to make this work with perf-with-kcore script? looks like we endup with kcore and won't allow vmlinux lookups for debug info thanks, jirka