From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Ezequiel Garcia <ezequiel@collabora.com>
Cc: linux-kernel@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
kernel@collabora.com,
Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Gustavo Padovan <gustavo.padovan@collabora.com>,
Matthias Brugger <mbrugger@suse.com>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] kref/kobject: Improve documentation
Date: Thu, 6 Dec 2018 13:57:30 +0100 [thread overview]
Message-ID: <20181206125730.GA30398@kroah.com> (raw)
In-Reply-To: <20181203164435.31530-1-ezequiel@collabora.com>
On Mon, Dec 03, 2018 at 01:44:35PM -0300, Ezequiel Garcia wrote:
> The current kref and kobject documentation may be
> insufficient to understand these common pitfalls regarding
> object lifetime and object releasing.
>
> Add a bit more documentation and improve the warnings
> seen by the user, pointing to the right piece of documentation.
>
> Also, it's important to understand that making fun of people
> publicly is not at all helpful, doesn't provide any value,
> and it's not a healthy way of encouraging developers to do better.
>
> "Mocking mercilessly" will, if anything, make developers feel bad
> and go away. This kind of behavior should not be encouraged or justified.
Very true, thanks for fixing this up and providing a much better wording
for all of this, including the warning messages.
Now queued up, thanks.
greg k-h
prev parent reply other threads:[~2018-12-06 12:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 16:44 [PATCH] kref/kobject: Improve documentation Ezequiel Garcia
2018-12-06 12:57 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181206125730.GA30398@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=enric.balletbo@collabora.com \
--cc=ezequiel@collabora.com \
--cc=gustavo.padovan@collabora.com \
--cc=kernel@collabora.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mbrugger@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox