From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EDC4FC04EB8 for ; Thu, 6 Dec 2018 14:40:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B415B21479 for ; Thu, 6 Dec 2018 14:40:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544107223; bh=PzxOqXvD7qffx0q7MsK1M+XXUFo/WQgouDolINY350w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jMlCjiL5EpFMPwVxJBzIqKO11TPQVYQFWS35lik4OSHzaBiCHe3GGxkJhEazjHnr3 MIwttFaIj+3a+7uI1JrS7zZk9mQ8uEy71ZzLTKd6UBzWoy4xFkztfpsG5VIn0HwG/n FVqxYPJICAEc9m/NhbDQrGFn2w+CZCqmHZQ7JLO4= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B415B21479 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729931AbeLFOkW (ORCPT ); Thu, 6 Dec 2018 09:40:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:44366 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729899AbeLFOkS (ORCPT ); Thu, 6 Dec 2018 09:40:18 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8055E208E7; Thu, 6 Dec 2018 14:40:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544107218; bh=PzxOqXvD7qffx0q7MsK1M+XXUFo/WQgouDolINY350w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=JZ8VICIGLReptWb7vu64pTIviAKtxV5aGs8QocWIMHlj3NXl0RyDIiNAhkyqWDdPS LPVL/Sq7N15FVuF55xWaBm465EPaGVGsAvsGyrXVfMwENnNoP7h3q2HMCHaEh71rvA eqPDDIsAVyGV5lSHSWdIfOfFKY1fXjnWcMEKKN5w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Linus Torvalds Subject: [PATCH 4.19 02/41] test_hexdump: use memcpy instead of strncpy Date: Thu, 6 Dec 2018 15:38:42 +0100 Message-Id: <20181206142949.956412491@linuxfoundation.org> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20181206142949.757402551@linuxfoundation.org> References: <20181206142949.757402551@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.19-stable review patch. If anyone has any objections, please let me know. ------------------ From: Linus Torvalds commit b1286ed7158e9b62787508066283ab0b8850b518 upstream. New versions of gcc reasonably warn about the odd pattern of strncpy(p, q, strlen(q)); which really doesn't make sense: the strncpy() ends up being just a slow and odd way to write memcpy() in this case. Apparently there was a patch for this floating around earlier, but it got lost. Acked-again-by: Andy Shevchenko Signed-off-by: Linus Torvalds Signed-off-by: Greg Kroah-Hartman --- lib/test_hexdump.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/lib/test_hexdump.c +++ b/lib/test_hexdump.c @@ -99,7 +99,7 @@ static void __init test_hexdump_prepare_ const char *q = *result++; size_t amount = strlen(q); - strncpy(p, q, amount); + memcpy(p, q, amount); p += amount; *p++ = ' ';