Re: [PATCH v2 6/6] arm, unicore32: remove early_alloc*() wrappers

Rob Herring
2018-12-03T16:27:20Z

On Mon, Dec 3, 2018 at 9:48 AM Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> On arm and unicore32i the early_alloc_aligned() and and early_alloc() are
> oneliner wrappers for memblock_alloc.
>
> Replace their usage with direct call to memblock_alloc.
>
> Suggested-by: Christoph Hellwig <hch@infradead.org>
> Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
> ---
> arch/arm/mm/mmu.c | 11 +++--------
> arch/unicore32/mm/mmu.c | 12 ++++--------
> 2 files changed, 7 insertions(+), 16 deletions(-)
>
> diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c
> index 0a04c9a5..57de0dd 100644
> --- a/arch/arm/mm/mmu.c
> +++ b/arch/arm/mm/mmu.c
> @@ -719,14 +719,9 @@ EXPORT_SYMBOL(phys_mem_access_prot);
>
> #define vectors_base() (vectors_high() ? 0xffff0000 : 0)
>
> -static void __init *early_alloc_aligned(unsigned long sz, unsigned long align)
> -{
> - return memblock_alloc(sz, align);
> -}
> -
> static void __init *early_alloc(unsigned long sz)

Why not get rid of this wrapper like you do on unicore?

> {
> - return early_alloc_aligned(sz, sz);
> + return memblock_alloc(sz, sz);
> }