public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: [PATCH 8/8] clk: Loongson1: Remove usage of CLK_IS_BASIC
Date: Thu,  6 Dec 2018 13:58:58 -0800	[thread overview]
Message-ID: <20181206215858.3880-9-sboyd@kernel.org> (raw)
In-Reply-To: <20181206215858.3880-1-sboyd@kernel.org>

This flag doesn't look to be used by any code, just set in the clk init
structure and then never tested again. Remove it from this driver as it
doesn't provide any benefit. Also remove parenthesis nearby that are not
needed and include clk.h to fix a sparse warning about static function
definition.

Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
 drivers/clk/loongson1/clk.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/loongson1/clk.c b/drivers/clk/loongson1/clk.c
index cfcfd143fccb..983ce9f6edbb 100644
--- a/drivers/clk/loongson1/clk.c
+++ b/drivers/clk/loongson1/clk.c
@@ -10,6 +10,8 @@
 #include <linux/clk-provider.h>
 #include <linux/slab.h>
 
+#include "clk.h"
+
 struct clk_hw *__init clk_hw_register_pll(struct device *dev,
 					  const char *name,
 					  const char *parent_name,
@@ -27,9 +29,9 @@ struct clk_hw *__init clk_hw_register_pll(struct device *dev,
 
 	init.name = name;
 	init.ops = ops;
-	init.flags = flags | CLK_IS_BASIC;
-	init.parent_names = (parent_name ? &parent_name : NULL);
-	init.num_parents = (parent_name ? 1 : 0);
+	init.flags = flags;
+	init.parent_names = parent_name ? &parent_name : NULL;
+	init.num_parents = parent_name ? 1 : 0;
 	hw->init = &init;
 
 	/* register the clock */
-- 
Sent by a computer through tubes


  parent reply	other threads:[~2018-12-06 21:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06 21:58 [PATCH 0/8] Remove CLK_IS_BASIC usage from clk drivers Stephen Boyd
2018-12-06 21:58 ` [PATCH 1/8] clk: renesas: Remove usage of CLK_IS_BASIC Stephen Boyd
2018-12-07  8:27   ` Geert Uytterhoeven
2018-12-07 20:41     ` Stephen Boyd
2018-12-13 19:48   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 2/8] clk: st: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 3/8] clk: axm5516: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 4/8] clk: h8300: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 5/8] clk: hisilicon: " Stephen Boyd
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 6/8] clk: versatile: sp810: " Stephen Boyd
2018-12-06 22:03   ` Linus Walleij
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` [PATCH 7/8] clk: samsung: s3c2410: " Stephen Boyd
2018-12-07  8:45   ` Krzysztof Kozlowski
2018-12-13 19:49   ` Stephen Boyd
2018-12-06 21:58 ` Stephen Boyd [this message]
2018-12-13 19:49   ` [PATCH 8/8] clk: Loongson1: " Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181206215858.3880-9-sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox