RE: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"

Clark Wang
2018-12-08T05:42:52Z

Hi Joe,

This patch series adds slave mode for lpspi controller. So this driver can support both master and slave mode for lpspi controller after apply this patch series. Currently, both master mode and slave mode share the code in this driver. Therefore, using spi_master to represent the structure of slave mode will cause confusion.

When Geert Uytterhoeven add the slave support for spi, he had done " Generalize SPI 'master' to 'controller'" step, too. The commit ID is 8caab75fd2c2a92667cbb1cd315720bede3feaa9.

Thank you.

Regards,
Clark Wang

> -----Original Message-----
> From: Joe Perches <joe@perches.com>
> Sent: Saturday, December 8, 2018 13:14
> To: Clark Wang <xiaoning.wang@nxp.com>; broonie@kernel.org
> Cc: linux-spi@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH V3 1/4] spi: lpspi: Replace all "master" with "controller"
>
> On Fri, 2018-12-07 at 02:50 +0000, Clark Wang wrote:
> > In order to enable the slave mode and make the code more readable,
> > replace all related structure names and object names which is named
> > "master" with "controller".
>
> In what sense does this make the code more readable?
>