From: Kyle Williams <kdgwill@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org,
"Kai-Heng Feng" <kai.heng.feng@canonical.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Jack Stocker" <jackstocker.93@gmail.com>,
"Michael Niewöhner" <linux@mniewoehner.de>,
"Nico Sneck" <snecknico@gmail.com>,
"Tim Anderson" <tsa@biglakesoftware.com>,
"Danilo Krummrich" <danilokrummrich@dk-develop.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally
Date: Fri, 7 Dec 2018 17:21:38 -0500 [thread overview]
Message-ID: <20181207222138.GB161210@google.com> (raw)
In-Reply-To: <20181205093902.GA18633@kroah.com>
On Wed, Dec 05, 2018 at 10:39:02AM +0100, Greg Kroah-Hartman wrote:
> On Tue, Dec 04, 2018 at 03:38:25PM -0500, Kyle Williams wrote:
> > Description: Some USB device / host controller combinations seem to have
> > problems with Link Power management. In particular it is described that
> > the combination of certain Logitech devices and other powered media
> > devices such as the Atrus device causes 'not enough bandwidth for
> > new device state'error.
> >
> > This patch creates quirk entries for the tested Logitech device
> > indicating LPM should remain disabled for the device.
> >
> > Signed-off-by: Kyle Williams <kdgwill@chromium.org>
> > ---
> > drivers/usb/core/quirks.c | 16 ++++++++++++++++
> > 1 file changed, 16 insertions(+)
>
> Along with what Alan said, this patch was sent in html mode, making it
> impossible to apply, and it was rejected by the mailing lists.
>
> Please fix up your email client before resending patches. Or just use
> 'git send-email'.
>
> thanks,
>
> greg k-h
Thanks for explaining why the patches were being rejected by the mailing
lists. I will move to using git send-email for sending patches and mutt
for sending replies in the future.
Kyle Williams
next prev parent reply other threads:[~2018-12-07 22:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAAd214WBzcsFamzqkdTp0AYDRo1=Uq1=Z5fJhzkOZ6znVFo3MA@mail.gmail.com>
2018-12-04 21:36 ` [PATCH] USB: quirks: add NO_LPM quirk for Logitech Flare|Meetup|Brio|Rally Alan Stern
2018-12-07 22:18 ` Kyle Williams
2018-12-10 13:50 ` Mathias Nyman
2019-01-10 14:36 ` Kyle Williams
2018-12-05 9:39 ` Greg Kroah-Hartman
2018-12-07 22:21 ` Kyle Williams [this message]
2018-12-08 0:46 ` [PATCH v2] USB: quirks: disable LPM for Logitech UVC devices Kyle Williams
2018-12-08 1:47 ` [PATCH v3 0/2] Disable LPM by matching interface Kyle Williams
2018-12-08 1:47 ` [PATCH v3 1/2] USB: quirks: Check device interface LPM capability Kyle Williams
2018-12-12 11:37 ` Greg Kroah-Hartman
2019-01-10 15:49 ` Kyle Williams
2019-01-11 9:09 ` Greg Kroah-Hartman
2018-12-08 1:47 ` [PATCH v3 2/2] USB: quirks: Disable LPM for Logitech UVC devices Kyle Williams
2018-12-12 11:37 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181207222138.GB161210@google.com \
--to=kdgwill@chromium.org \
--cc=danilokrummrich@dk-develop.de \
--cc=gregkh@linuxfoundation.org \
--cc=jackstocker.93@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux@mniewoehner.de \
--cc=snecknico@gmail.com \
--cc=stern@rowland.harvard.edu \
--cc=tsa@biglakesoftware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox