From: Jonathan Cameron <jic23@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: Himanshu Jha <himanshujha199640@gmail.com>,
Marcelo Schmitt <marcelo.schmitt1@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
lars@metafoo.de, Michael.Hennerich@analog.com, knaack.h@gmx.de,
pmeerw@pmeerw.net, gregkh@linuxfoundation.org,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-usp@googlegroups.com
Subject: Re: [PATCH] staging: iio: ad5933: add binding doc for ad5933
Date: Sat, 8 Dec 2018 11:05:33 +0000 [thread overview]
Message-ID: <20181208110533.07d66422@archlinux> (raw)
In-Reply-To: <772d86622aea17e1c7b5ac05e096f1a129fc86b4.camel@perches.com>
On Sun, 02 Dec 2018 15:22:15 -0800
Joe Perches <joe@perches.com> wrote:
> On Mon, 2018-12-03 at 00:20 +0530, Himanshu Jha wrote:
> > On Sun, Dec 02, 2018 at 02:57:12PM -0200, Marcelo Schmitt wrote:
> > > Add a devicetree documentation for the ad5933 and ad5934 impedance
> > > converter, network analyzer.
> > >
> > > Co-Developed-by: Gabriel Capella <gabriel@capella.pro>
> >
> > checkpatch spits out:
> >
> > WARNING: Non-standard signature: Co-Developed-by:
> >
> > Co-developed-by Vs Co-Developed-by ?
> >
> > Documentation/process/5.Posting.rst: - Co-developed-by: states that the patch was also created by another developer
> > Documentation/process/submitting-patches.rst:12) When to use Acked-by:, Cc:, and Co-Developed-by:
> >
> > Confusing! Don't know which one is correct.
>
> I think neither one.
>
> What's the real purpose or value of it?
> There isn't one as far as I can tell.
>
> Just use Signed-off-by:
>
> Or maybe add multiple "Authored-by:" if
> anyone is all that concerned about authorship
> crediting...
This is output of pair programming so only fair to acknowledge
both developers (or more if a larger group). Right now
we have a guide that says Co-developed-by is the way to do that.
I would stick to that. If people feel something else makes sense
then they should propose a change to the documentation and
hopefully we can reach some agreement on this.
I'm happy with Co-developed-by in IIO as I think it's a fair
reflection of what happened. Authored-by would be fine but
isn't a standard tag documented anywhere.
Jonathan
>
>
> >
> > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com>
> > > Signed-off-by: Gabriel Capella <gabriel@capella.pro>
> > > ---
> >
> > Use `./scripts/get_maintainer.pl <your_patch>` to list the DT
> > maintainers and the relevant mailing list.
> >
> >
>
next prev parent reply other threads:[~2018-12-08 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-02 16:57 [PATCH] staging: iio: ad5933: add binding doc for ad5933 Marcelo Schmitt
2018-12-02 18:50 ` Himanshu Jha
2018-12-02 23:22 ` Joe Perches
2018-12-08 11:05 ` Jonathan Cameron [this message]
2018-12-03 13:16 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181208110533.07d66422@archlinux \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=akpm@linux-foundation.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=himanshujha199640@gmail.com \
--cc=joe@perches.com \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.schmitt1@gmail.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox