public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Masami Hiramatsu <mhiramat@kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Peter Zijlstra <peterz@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andy Lutomirski <luto@amacapital.net>
Subject: Re: Strange hang with gcc 8 of kprobe multiple_kprobes test
Date: Sun, 9 Dec 2018 23:01:27 +0100	[thread overview]
Message-ID: <20181209220127.GA84159@gmail.com> (raw)
In-Reply-To: <20181204143830.6c7f8910@vmware.local.home>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Tue, 4 Dec 2018 09:15:06 +0100
> Ingo Molnar <mingo@kernel.org> wrote:
> 
> > * Masami Hiramatsu <mhiramat@kernel.org> wrote:
> > 
> > > I remember I have fixed this, and actually WE did it :-D
> > > 
> > > https://lkml.org/lkml/2018/8/23/1203
> > > 
> > > Ah, we hit a same bug...
> > > 
> > > Ingo, could you pick the patch? Should I resend it?  
> > 
> > Indeed: I just picked it up into tip:perf/urgent.
> > 
> > It's my bad: I missed the original submission due to Steve's feedback 
> > which I mistook as a request for another iteration, while he only 
> > commented on the reason for the original breakage and gave his 
> > Reviewed-by ...
> > 
> 
> Sorry for the confusion. The patch and code was quite complex, and I
> was documenting what I thought of the patch (and the bug), so that my
> Reviewed-by had a bit more meaning.

It was totally welcome when I read it the second time - and it's my bad I 
was reading too quickly first time around ;-)

So please keep doing it whenever you find the time! :)

Thanks,

	Ingo

      reply	other threads:[~2018-12-09 22:01 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-04  2:18 Strange hang with gcc 8 of kprobe multiple_kprobes test Steven Rostedt
2018-12-04  7:40 ` Masami Hiramatsu
2018-12-04  8:02   ` Masami Hiramatsu
2018-12-04  8:15     ` Ingo Molnar
2018-12-04 19:38       ` Steven Rostedt
2018-12-09 22:01         ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181209220127.GA84159@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=mhiramat@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox