From: Lee Jones <lee.jones@linaro.org>
To: "Oskari Lemmelä" <oskari@lemmela.net>
Cc: Chen-Yu Tsai <wens@csie.org>,
Quentin Schulz <quentin.schulz@bootlin.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 1/2] mfd: axp20x: Re-align mfd cell entries
Date: Mon, 10 Dec 2018 07:05:16 +0000 [thread overview]
Message-ID: <20181210070516.GW26661@dell> (raw)
In-Reply-To: <c77951e6-46d9-d48a-b5bb-33bb9d00a929@lemmela.net>
On Mon, 10 Dec 2018, Oskari Lemmelä wrote:
> On 10.12.2018 8.36, Lee Jones wrote:
> > On Sat, 08 Dec 2018, Oskari Lemmela wrote:
> >
> >> From: Chen-Yu Tsai <wens@csie.org>
> >>
> >> In the axp20x driver, the various mfd_cell lists had varying amounts
> >> of indentation, sometimes even within the same list. For the axp288,
> >> there's no alignment at all.
> >>
> >> Re-align the right hand side of the assignments with the least amount
> >> of tabs possible. Also collapse the closing bracket and the opening
> >> bracket of the next entry onto the same line for the axp288, to be
> >> consistent with all the other mfd_cell lists.
> >>
> >> This patch is whitespace change only. No functionality is modified.
> >>
> >> Signed-off-by: Chen-Yu Tsai <wens@csie.org>
> >> Signed-off-by: Oskari Lemmela <oskari@lemmela.net>
> > Why is Oskari Lemmela's SoB here?
> >
> > You both authored this alignment patch?
> I picked up Chen-Yu's patch from
> https://github.com/wens/linux/commit/b99cec26bae2835a0374463570ea9ea26b034afa.
> I should have mentioned it cover letter.
>
> Chen-Yu is correct author. I'm just sending his patch.
That's fine. Thanks for the explanation.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-10 7:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-08 17:58 [PATCH v8 0/2] AXP8x3 AC and battery power supply support Oskari Lemmela
2018-12-08 17:58 ` [PATCH v8 1/2] mfd: axp20x: Re-align mfd cell entries Oskari Lemmela
2018-12-10 6:32 ` Lee Jones
2018-12-10 6:36 ` Lee Jones
2018-12-10 6:55 ` Oskari Lemmelä
2018-12-10 7:05 ` Lee Jones [this message]
2018-12-08 17:58 ` [PATCH v8 2/2] mfd: axp20x: Add supported cells for AXP803 Oskari Lemmela
2018-12-10 6:32 ` Lee Jones
2018-12-10 6:35 ` Lee Jones
2018-12-10 6:41 ` Chen-Yu Tsai
2018-12-10 7:04 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210070516.GW26661@dell \
--to=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oskari@lemmela.net \
--cc=quentin.schulz@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox