From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAA85C04EB8 for ; Mon, 10 Dec 2018 08:40:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A58A120865 for ; Mon, 10 Dec 2018 08:40:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A58A120865 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zeniv.linux.org.uk Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726622AbeLJIkP (ORCPT ); Mon, 10 Dec 2018 03:40:15 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:46248 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726029AbeLJIkP (ORCPT ); Mon, 10 Dec 2018 03:40:15 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.91 #2 (Red Hat Linux)) id 1gWH6Z-0001LW-LR; Mon, 10 Dec 2018 08:39:55 +0000 Date: Mon, 10 Dec 2018 08:39:55 +0000 From: Al Viro To: Chanho Min Cc: Andrew Morton , Kees Cook , "Eric W. Biederman" , "David S. Miller" , Michal Hocko , Alexei Starovoitov , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Seungho Park Subject: Re: [PATCH] exec: make prepare_bprm_creds static Message-ID: <20181210083955.GE2217@ZenIV.linux.org.uk> References: <1544428194-2431-1-git-send-email-chanho.min@lge.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1544428194-2431-1-git-send-email-chanho.min@lge.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 10, 2018 at 04:49:54PM +0900, Chanho Min wrote: > prepare_bprm_creds is not used outside exec.c, so there's no reason for it > to have external linkage. Applied...