From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19BCEC04EB8 for ; Mon, 10 Dec 2018 11:28:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DA76B2084E for ; Mon, 10 Dec 2018 11:28:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DA76B2084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727468AbeLJL2W (ORCPT ); Mon, 10 Dec 2018 06:28:22 -0500 Received: from mail.bootlin.com ([62.4.15.54]:57859 "EHLO mail.bootlin.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726292AbeLJL2V (ORCPT ); Mon, 10 Dec 2018 06:28:21 -0500 Received: by mail.bootlin.com (Postfix, from userid 110) id 1608A2079D; Mon, 10 Dec 2018 12:28:19 +0100 (CET) Received: from bbrezillon (unknown [91.160.177.164]) by mail.bootlin.com (Postfix) with ESMTPSA id CA4232037D; Mon, 10 Dec 2018 12:28:18 +0100 (CET) Date: Mon, 10 Dec 2018 12:28:18 +0100 From: Boris Brezillon To: Vignesh R Cc: Marek Vasut , Rob Herring , Brian Norris , Yogesh Gaur , Linux ARM Mailing List , , , Subject: Re: [PATCH 3/3] mtd: spi-nor: cadence-quadspi: Add support for Octal SPI controller Message-ID: <20181210122818.15de3232@bbrezillon> In-Reply-To: References: <20181003165603.2579-1-vigneshr@ti.com> <20181003165603.2579-4-vigneshr@ti.com> <20181210094513.6282d55e@bbrezillon> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Dec 2018 16:49:29 +0530 Vignesh R wrote: > On 10/12/18 2:15 PM, Boris Brezillon wrote: > > On Wed, 3 Oct 2018 22:26:03 +0530 > > Vignesh R wrote: > > > >> Cadence OSPI controller IP supports Octal IO (x8 IO lines), > >> It also has an integrated PHY. IP register layout is very > >> similar to existing QSPI IP except for additional bits to support Octal > >> and Octal DDR mode. Therefore, extend current driver to support Octal > >> mode. > >> > >> Signed-off-by: Vignesh R > >> --- > >> drivers/mtd/spi-nor/cadence-quadspi.c | 9 +++++++++ > >> 1 file changed, 9 insertions(+) > >> > >> diff --git a/drivers/mtd/spi-nor/cadence-quadspi.c b/drivers/mtd/spi-nor/cadence-quadspi.c > >> index e24db817154e..48b00e75a879 100644 > >> --- a/drivers/mtd/spi-nor/cadence-quadspi.c > >> +++ b/drivers/mtd/spi-nor/cadence-quadspi.c > >> @@ -101,6 +101,7 @@ struct cqspi_st { > >> #define CQSPI_INST_TYPE_SINGLE 0 > >> #define CQSPI_INST_TYPE_DUAL 1 > >> #define CQSPI_INST_TYPE_QUAD 2 > >> +#define CQSPI_INST_TYPE_OCTAL 3 > >> > >> #define CQSPI_DUMMY_CLKS_PER_BYTE 8 > >> #define CQSPI_DUMMY_BYTES_MAX 4 > >> @@ -898,6 +899,9 @@ static int cqspi_set_protocol(struct spi_nor *nor, const int read) > >> case SNOR_PROTO_1_1_4: > >> f_pdata->data_width = CQSPI_INST_TYPE_QUAD; > >> break; > >> + case SNOR_PROTO_1_1_8: > >> + f_pdata->data_width = CQSPI_INST_TYPE_OCTAL; > >> + break; > >> default: > >> return -EINVAL; > >> } > >> @@ -1205,6 +1209,7 @@ static int cqspi_setup_flash(struct cqspi_st *cqspi, struct device_node *np) > >> SNOR_HWCAPS_READ_FAST | > >> SNOR_HWCAPS_READ_1_1_2 | > >> SNOR_HWCAPS_READ_1_1_4 | > >> + SNOR_HWCAPS_READ_1_1_8 | > > > > Is this really supported on qspi versions of this IP? I guess not given > > the description in the commit message and the name of the new > > compatible (ospi instead of qspi). > > No, qspi version does not support Octal mode. I guess you are pointing > out its logically wrong for driver with "*-qspi" compatible to declare > SNOR_HWCAPS_READ_1_1_8 capability. Exactly. > Will update patch to declare SNOR_HWCAPS_READ_1_1_8 based on compatible. Thanks.