From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B9AAC07E85 for ; Tue, 11 Dec 2018 15:42:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C41C420855 for ; Tue, 11 Dec 2018 15:42:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544542954; bh=8cYC0oLK63JYlIjF4F+CBzceJxrjCp/Xu/qzBnDAsXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=zCaPDslmU+9yM42v05ryjW8Ff8GzGn70MvXoe67rHvUFjkf2g9oE2g+mlQdtjssEa 5N90X3x8AjICHvQCaAYw2xcLc9qTstwSJFmzOb8/57OlYDm3IOMjvGKaKUIzgjr3u9 4cmc58xHfV0zbbcEUHQTRHoniKD1/DgoTxNoUls4= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C41C420855 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727264AbeLKPmd (ORCPT ); Tue, 11 Dec 2018 10:42:33 -0500 Received: from mail.kernel.org ([198.145.29.99]:58894 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726452AbeLKPmb (ORCPT ); Tue, 11 Dec 2018 10:42:31 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 74FD42082F; Tue, 11 Dec 2018 15:42:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544542951; bh=8cYC0oLK63JYlIjF4F+CBzceJxrjCp/Xu/qzBnDAsXU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=v7wZmp8KmbOmodTJbI793f9LiyGVnOgW286IG5rQ4N7CW3qo0exjZqaBIaNTnGw5d cKXoNklaxmLiozt+HKyUgl4vh6kfdF/ukUrxzkNUlIxSrWSRbRUi3Te1Bruh72IYRY STjz3B1+0vZUP6pLg5ol3drF+wA9U2eRbqpv9LTQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pan Bian , "David S. Miller" Subject: [PATCH 3.18 02/54] rapidio/rionet: do not free skb before reading its length Date: Tue, 11 Dec 2018 16:40:50 +0100 Message-Id: <20181211151546.123868470@linuxfoundation.org> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20181211151546.010073210@linuxfoundation.org> References: <20181211151546.010073210@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 3.18-stable review patch. If anyone has any objections, please let me know. ------------------ From: Pan Bian [ Upstream commit cfc435198f53a6fa1f656d98466b24967ff457d0 ] skb is freed via dev_kfree_skb_any, however, skb->len is read then. This may result in a use-after-free bug. Fixes: e6161d64263 ("rapidio/rionet: rework driver initialization and removal") Signed-off-by: Pan Bian Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/rionet.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/rionet.c +++ b/drivers/net/rionet.c @@ -215,9 +215,9 @@ static int rionet_start_xmit(struct sk_b * it just report sending a packet to the target * (without actual packet transfer). */ - dev_kfree_skb_any(skb); ndev->stats.tx_packets++; ndev->stats.tx_bytes += skb->len; + dev_kfree_skb_any(skb); } }