From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B79C0C04EB8 for ; Wed, 12 Dec 2018 08:11:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 870152084E for ; Wed, 12 Dec 2018 08:11:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 870152084E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cn.fujitsu.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbeLLILA (ORCPT ); Wed, 12 Dec 2018 03:11:00 -0500 Received: from mail.cn.fujitsu.com ([183.91.158.132]:14882 "EHLO heian.cn.fujitsu.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726007AbeLLIK7 (ORCPT ); Wed, 12 Dec 2018 03:10:59 -0500 X-IronPort-AV: E=Sophos;i="5.56,343,1539619200"; d="scan'208";a="49588356" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 12 Dec 2018 16:10:57 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 06C704B734D9; Wed, 12 Dec 2018 16:10:58 +0800 (CST) Received: from localhost.localdomain (10.167.225.56) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 12 Dec 2018 16:11:03 +0800 Date: Wed, 12 Dec 2018 16:10:32 +0800 From: Chao Fan To: Baoquan He CC: , , , , , , , , , Subject: Re: [PATCH v13 1/6] x86/boot: Introduce kstrtoull() to boot directory instead of simple_strtoull() Message-ID: <20181212081032.GA24409@localhost.localdomain> References: <20181212031053.1815-1-fanc.fnst@cn.fujitsu.com> <20181212031053.1815-2-fanc.fnst@cn.fujitsu.com> <20181212074615.GO17340@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20181212074615.GO17340@MiWiFi-R3L-srv> User-Agent: Mutt/1.10.1 (2018-07-13) X-Originating-IP: [10.167.225.56] X-yoursite-MailScanner-ID: 06C704B734D9.AC9C6 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: fanc.fnst@cn.fujitsu.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 12, 2018 at 03:46:15PM +0800, Baoquan He wrote: >On 12/12/18 at 11:10am, Chao Fan wrote: >> Introduce kstrtoull() from lib/kstrtox.c to boot directory so that code > >It's not introducing kstrtoull(), just copying kstrtoull() from >lib/kstrtox.c to boot. Oops, maybe I misunderstand 'introduce'. Thanks, Chao Fan > >> in boot/ can use kstrtoull() and the old simple_strtoull() can be >> replaced. >> >> Signed-off-by: Chao Fan >> --- >> arch/x86/boot/string.c | 137 +++++++++++++++++++++++++++++++++++++++++ >> arch/x86/boot/string.h | 2 + >> 2 files changed, 139 insertions(+) >> >> diff --git a/arch/x86/boot/string.c b/arch/x86/boot/string.c >> index c4428a176973..e02405f20f98 100644 >> --- a/arch/x86/boot/string.c >> +++ b/arch/x86/boot/string.c >> @@ -12,7 +12,10 @@ >> * Very basic string functions >> */ >> >> +#define _LINUX_CTYPE_H >> #include >> +#include >> +#include >> #include >> #include "ctype.h" >> #include "string.h" >> @@ -187,3 +190,137 @@ char *strchr(const char *s, int c) >> return NULL; >> return (char *)s; >> } >> + >> +static inline u64 div_u64_rem(u64 dividend, u32 divisor, u32 *remainder) >> +{ >> + union { >> + u64 v64; >> + u32 v32[2]; >> + } d = { dividend }; >> + u32 upper; >> + >> + upper = d.v32[1]; >> + d.v32[1] = 0; >> + if (upper >= divisor) { >> + d.v32[1] = upper / divisor; >> + upper %= divisor; >> + } >> + asm ("divl %2" : "=a" (d.v32[0]), "=d" (*remainder) : >> + "rm" (divisor), "0" (d.v32[0]), "1" (upper)); >> + return d.v64; >> +} >> + >> +static inline u64 div_u64(u64 dividend, u32 divisor) >> +{ >> + u32 remainder; >> + return div_u64_rem(dividend, divisor, &remainder); >> +} >> + >> +static inline char _tolower(const char c) >> +{ >> + return c | 0x20; >> +} >> + >> +const char *_parse_integer_fixup_radix(const char *s, unsigned int *base) >> +{ >> + if (*base == 0) { >> + if (s[0] == '0') { >> + if (_tolower(s[1]) == 'x' && isxdigit(s[2])) >> + *base = 16; >> + else >> + *base = 8; >> + } else >> + *base = 10; >> + } >> + if (*base == 16 && s[0] == '0' && _tolower(s[1]) == 'x') >> + s += 2; >> + return s; >> +} >> + >> +/* >> + * Convert non-negative integer string representation in explicitly given radix >> + * to an integer. >> + * Return number of characters consumed maybe or-ed with overflow bit. >> + * If overflow occurs, result integer (incorrect) is still returned. >> + * >> + * Don't you dare use this function. >> + */ >> +unsigned int _parse_integer(const char *s, unsigned int base, unsigned long long *p) >> +{ >> + unsigned long long res; >> + unsigned int rv; >> + >> + res = 0; >> + rv = 0; >> + while (1) { >> + unsigned int c = *s; >> + unsigned int lc = c | 0x20; /* don't tolower() this line */ >> + unsigned int val; >> + >> + if ('0' <= c && c <= '9') >> + val = c - '0'; >> + else if ('a' <= lc && lc <= 'f') >> + val = lc - 'a' + 10; >> + else >> + break; >> + >> + if (val >= base) >> + break; >> + /* >> + * Check for overflow only if we are within range of >> + * it in the max base we support (16) >> + */ >> + if (unlikely(res & (~0ull << 60))) { >> + if (res > div_u64(ULLONG_MAX - val, base)) >> + rv |= KSTRTOX_OVERFLOW; >> + } >> + res = res * base + val; >> + rv++; >> + s++; >> + } >> + *p = res; >> + return rv; >> +} >> + >> +static int _kstrtoull(const char *s, unsigned int base, unsigned long long *res) >> +{ >> + unsigned long long _res; >> + unsigned int rv; >> + >> + s = _parse_integer_fixup_radix(s, &base); >> + rv = _parse_integer(s, base, &_res); >> + if (rv & KSTRTOX_OVERFLOW) >> + return -ERANGE; >> + if (rv == 0) >> + return -EINVAL; >> + s += rv; >> + if (*s == '\n') >> + s++; >> + if (*s) >> + return -EINVAL; >> + *res = _res; >> + return 0; >> +} >> + >> +/** >> + * kstrtoull - convert a string to an unsigned long long >> + * @s: The start of the string. The string must be null-terminated, and may also >> + * include a single newline before its terminating null. The first character >> + * may also be a plus sign, but not a minus sign. >> + * @base: The number base to use. The maximum supported base is 16. If base is >> + * given as 0, then the base of the string is automatically detected with the >> + * conventional semantics - If it begins with 0x the number will be parsed as a >> + * hexadecimal (case insensitive), if it otherwise begins with 0, it will be >> + * parsed as an octal number. Otherwise it will be parsed as a decimal. >> + * @res: Where to write the result of the conversion on success. >> + * >> + * Returns 0 on success, -ERANGE on overflow and -EINVAL on parsing error. >> + * Used as a replacement for the obsolete simple_strtoull. Return code must >> + * be checked. >> + */ >> +int kstrtoull(const char *s, unsigned int base, unsigned long long *res) >> +{ >> + if (s[0] == '+') >> + s++; >> + return _kstrtoull(s, base, res); >> +} >> diff --git a/arch/x86/boot/string.h b/arch/x86/boot/string.h >> index 3d78e27077f4..171007c99acc 100644 >> --- a/arch/x86/boot/string.h >> +++ b/arch/x86/boot/string.h >> @@ -29,4 +29,6 @@ extern unsigned int atou(const char *s); >> extern unsigned long long simple_strtoull(const char *cp, char **endp, >> unsigned int base); >> >> +int kstrtoull(const char *s, unsigned int base, unsigned long long *res); >> +#define KSTRTOX_OVERFLOW (1U << 31) >> #endif /* BOOT_STRING_H */ >> -- >> 2.19.2 >> >> >> > >