From: Peter Zijlstra <peterz@infradead.org>
To: Derek Basehore <dbasehore@chromium.org>
Cc: mingo@redhat.com, will.deacon@arm.com, linux-kernel@vger.kernel.org
Subject: Re: RFC [PATCH 1/1] locking/lockdep: Fix nest lock warning on unlock
Date: Wed, 12 Dec 2018 10:09:01 +0100 [thread overview]
Message-ID: <20181212090901.GV5289@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20181212022506.171936-2-dbasehore@chromium.org>
On Tue, Dec 11, 2018 at 06:25:06PM -0800, Derek Basehore wrote:
> The function __lock_acquire checks that the nest lock is held passed
> in as an argument. The issue with this is that __lock_acquire is used
> for internal bookkeeping on lock_release. This produces a false
> positive lockdep warning on unlock. Since you explicitly don't need to
> hold the nest lock on unlock, this is an issue.
Who is triggering this?
next prev parent reply other threads:[~2018-12-12 9:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 2:25 RFC [PATCH 0/1] Fix lockdep false positive Derek Basehore
2018-12-12 2:25 ` RFC [PATCH 1/1] locking/lockdep: Fix nest lock warning on unlock Derek Basehore
2018-12-12 9:09 ` Peter Zijlstra [this message]
2018-12-12 11:42 ` dbasehore .
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212090901.GV5289@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dbasehore@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox