From: Borislav Petkov <bp@alien8.de>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: "Lendacky, Thomas" <Thomas.Lendacky@amd.com>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andrea Arcangeli <aarcange@redhat.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Jiri Kosina <jkosina@suse.cz>, Ingo Molnar <mingo@redhat.com>,
Tim Chen <tim.c.chen@linux.intel.com>,
David Woodhouse <dwmw@amazon.co.uk>
Subject: Re: [PATCH v2] x86/speculation: Add support for STIBP always-on preferred mode
Date: Wed, 12 Dec 2018 10:59:38 +0100 [thread overview]
Message-ID: <20181212095938.GA6653@zn.tnic> (raw)
In-Reply-To: <alpine.DEB.2.21.1812111910520.22893@nanos.tec.linutronix.de>
On Tue, Dec 11, 2018 at 07:37:26PM -0800, Thomas Gleixner wrote:
> Hmmm. I've not seen the V1 of this (it's not in my inbox) but the v1->v2
> changes contain:
You're on CC:
https://lkml.kernel.org/r/20181211190959.28321.56433.stgit@tlendack-t1.amdoffice.net
>
> > > - Removed explicit SPECTRE_V2_USER_STRICT_PREFERRED mode
>
> Now I really have to ask why?
>
> Neither the extra variable nor the cpu feature check are pretty. An
> explicit mode is way better in terms of code clarity and you get the proper
> printout via spectre_v2_user_strings.
Actually, now that I've slept on it, I think we should do this just
like X86_FEATURE_IBRS_ENHANCED - as a modifier for SPECTRE_V2_CMD_AUTO
or _FORCE options.
And that has its own mode SPECTRE_V2_IBRS_ENHANCED.
Makes sense?
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-12-12 9:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-11 22:46 [PATCH v2] x86/speculation: Add support for STIBP always-on preferred mode Lendacky, Thomas
2018-12-12 0:05 ` Borislav Petkov
2018-12-12 3:37 ` Thomas Gleixner
2018-12-12 9:59 ` Borislav Petkov [this message]
2018-12-12 14:04 ` Lendacky, Thomas
2018-12-12 14:32 ` Boris Petkov
2018-12-12 15:01 ` Lendacky, Thomas
2018-12-12 14:03 ` Lendacky, Thomas
2018-12-12 14:23 ` Thomas Gleixner
2018-12-12 15:04 ` Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212095938.GA6653@zn.tnic \
--to=bp@alien8.de \
--cc=Thomas.Lendacky@amd.com \
--cc=aarcange@redhat.com \
--cc=dwmw@amazon.co.uk \
--cc=jkosina@suse.cz \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=tim.c.chen@linux.intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox