From: Thierry Reding <thierry.reding@gmail.com>
To: "Michal Vokáč" <michal.vokac@ysoft.com>
Cc: linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] pwm: imx: Use bitops and bitfield macros to define register values
Date: Wed, 12 Dec 2018 11:53:04 +0100 [thread overview]
Message-ID: <20181212105304.GC17654@ulmo> (raw)
In-Reply-To: <1538403588-68850-2-git-send-email-michal.vokac@ysoft.com>
[-- Attachment #1: Type: text/plain, Size: 435 bytes --]
On Mon, Oct 01, 2018 at 04:19:47PM +0200, Michal Vokáč wrote:
> Use existing macros to define register fields instead of manually shifting
> the bit masks. Also define some more register bits.
>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> drivers/pwm/pwm-imx.c | 78 ++++++++++++++++++++++++++++++++++++++-------------
> 1 file changed, 58 insertions(+), 20 deletions(-)
Applied, thanks.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-12 10:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 14:19 [PATCH 1/3] pwm: imx: Sort include files Michal Vokáč
2018-10-01 14:19 ` [PATCH 2/3] pwm: imx: Use bitops and bitfield macros to define register values Michal Vokáč
2018-12-12 10:53 ` Thierry Reding [this message]
2018-12-12 10:55 ` [2/3] " Uwe Kleine-König
2018-10-01 14:19 ` [PATCH 3/3] pwm: imx: Implement get_state() function for hardware readout Michal Vokáč
2018-12-12 10:51 ` [3/3] " Uwe Kleine-König
2018-12-14 16:40 ` Vokáč Michal
2018-12-12 10:54 ` [PATCH 3/3] " Thierry Reding
2018-12-13 8:52 ` Uwe Kleine-König
2018-12-13 17:00 ` Thierry Reding
2018-12-13 20:14 ` Uwe Kleine-König
2018-12-14 16:57 ` Vokáč Michal
2018-12-12 10:52 ` [PATCH 1/3] pwm: imx: Sort include files Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212105304.GC17654@ulmo \
--to=thierry.reding@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michal.vokac@ysoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox