From: Olof Johansson <olof@lixom.net>
To: Arnd Bergmann <arnd@arndb.de>
Cc: arm@kernel.org, Lubomir Rintel <lkundrak@v3.sk>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] ARM: mmp: fix pxa168_device_usb_phy use on aspenite
Date: Wed, 12 Dec 2018 13:55:35 -0800 [thread overview]
Message-ID: <20181212215535.5evv7fk7ed57gw7s@localhost> (raw)
In-Reply-To: <20181210204340.2269622-2-arnd@arndb.de>
On Mon, Dec 10, 2018 at 09:43:02PM +0100, Arnd Bergmann wrote:
> This one ended up in the wrong header file, causing a build failure
> on at least one platform:
>
> arch/arm/mach-mmp/aspenite.c: In function 'common_init':
> arch/arm/mach-mmp/aspenite.c:260:28: error: 'pxa168_device_usb_phy' undeclared (first use in this function); did you mean 'pxa168_device_ssp5'?
>
> We can just include both the pxa168.h and pxa910.h headers to make
> that work, which gets us to the next failure:
>
> arch/arm/mach-mmp/aspenite.o: In function `common_init':
> aspenite.c:(.init.text+0x1c0): undefined reference to `pxa168_device_usb_phy'
>
> This is solved by using the matching ifdef check around the
> USB device registration, enabling them only when either USB
> host or gadget mode are enabled.
>
> Fixes: a225daf72ee7 ("ARM: mmp: add a pxa-usb-phy device")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to next/soc. Thanks!
-Olof
next prev parent reply other threads:[~2018-12-12 22:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 20:43 [PATCH 1/2] ARM: mmp: fix timer_init calls Arnd Bergmann
2018-12-10 20:43 ` [PATCH 2/2] ARM: mmp: fix pxa168_device_usb_phy use on aspenite Arnd Bergmann
2018-12-12 21:55 ` Olof Johansson [this message]
2018-12-12 21:55 ` [PATCH 1/2] ARM: mmp: fix timer_init calls Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181212215535.5evv7fk7ed57gw7s@localhost \
--to=olof@lixom.net \
--cc=arm@kernel.org \
--cc=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox