From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4645C65BAE for ; Thu, 13 Dec 2018 04:30:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7F38E20880 for ; Thu, 13 Dec 2018 04:30:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675447; bh=Z4ZwdEY946Inu2LEbt5cy9Cjm55DmwBRG3Ex2mZbTp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=T2pbcuJXH8HxkCYljRdWBFPFXYS+AcxrXCSGsZGblzZwaHLgsMMQ8EnPdFI7SJshx 7HXtCwWl3e+8AQiASJiKz/FZlZJo+PY87QXEI9tb262HJ/X7MyGCLzHnQJXtDJALSI mewWHwropPJKzEmOueL6g7aRg1mxgoQXJRYx7fnU= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7F38E20880 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727368AbeLMEaq (ORCPT ); Wed, 12 Dec 2018 23:30:46 -0500 Received: from mail.kernel.org ([198.145.29.99]:43522 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726907AbeLMEaj (ORCPT ); Wed, 12 Dec 2018 23:30:39 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2BBCA20879; Thu, 13 Dec 2018 04:30:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544675438; bh=Z4ZwdEY946Inu2LEbt5cy9Cjm55DmwBRG3Ex2mZbTp0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ovArJyZPKrwwFcNpjQOXSQ1d1Xr8G5h+9kT/S8O9Kcsl8QhNIP3IsjbE/1oyxP4Cg bxg5s61dp1pQV2Rkj30KDyithkXD1tZG2fYtOxEP9kDne0/EBmmoF9vzh0+PmEEyG/ XlqCXbXzgdtU9v7dIrSa5pemBiVAbpC9bAG//jus= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Steve French , Sasha Levin , linux-cifs@vger.kernel.org Subject: [PATCH AUTOSEL 4.19 63/73] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Date: Wed, 12 Dec 2018 23:28:28 -0500 Message-Id: <20181213042838.75160-63-sashal@kernel.org> X-Mailer: git-send-email 2.19.1 In-Reply-To: <20181213042838.75160-1-sashal@kernel.org> References: <20181213042838.75160-1-sashal@kernel.org> MIME-Version: 1.0 X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Steve French [ Upstream commit 6e785302dad32228819d8066e5376acd15d0e6ba ] Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky Signed-off-by: Sasha Levin --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index abcd78e332fe..85dadb93c992 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -133,7 +133,7 @@ config CIFS_XATTR config CIFS_POSIX bool "CIFS POSIX Extensions" - depends on CIFS_XATTR + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR help Enabling this option will cause the cifs client to attempt to negotiate a newer dialect with servers, such as Samba 3.0.5 -- 2.19.1