From: Sasha Levin <sashal@kernel.org>
To: linux-kernel@vger.kernel.org, stable@vger.kernel.org
Cc: Vladimir Murzin <vladimir.murzin@arm.com>,
Chris Cole <chris@sageembedded.com>,
Russell King <rmk+kernel@armlinux.org.uk>,
Sasha Levin <sashal@kernel.org>
Subject: [PATCH AUTOSEL 4.14 30/41] ARM: 8815/1: V7M: align v7m_dma_inv_range() with v7 counterpart
Date: Wed, 12 Dec 2018 23:30:43 -0500 [thread overview]
Message-ID: <20181213043054.75891-30-sashal@kernel.org> (raw)
In-Reply-To: <20181213043054.75891-1-sashal@kernel.org>
From: Vladimir Murzin <vladimir.murzin@arm.com>
[ Upstream commit 3d0358d0ba048c5afb1385787aaec8fa5ad78fcc ]
Chris has discovered and reported that v7_dma_inv_range() may corrupt
memory if address range is not aligned to cache line size.
Since the whole cache-v7m.S was lifted form cache-v7.S the same
observation applies to v7m_dma_inv_range(). So the fix just mirrors
what has been done for v7 with a little specific of M-class.
Cc: Chris Cole <chris@sageembedded.com>
Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---
arch/arm/mm/cache-v7m.S | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mm/cache-v7m.S b/arch/arm/mm/cache-v7m.S
index 788486e830d3..32aa2a2aa260 100644
--- a/arch/arm/mm/cache-v7m.S
+++ b/arch/arm/mm/cache-v7m.S
@@ -73,9 +73,11 @@
/*
* dcimvac: Invalidate data cache line by MVA to PoC
*/
-.macro dcimvac, rt, tmp
- v7m_cacheop \rt, \tmp, V7M_SCB_DCIMVAC
+.irp c,,eq,ne,cs,cc,mi,pl,vs,vc,hi,ls,ge,lt,gt,le,hs,lo
+.macro dcimvac\c, rt, tmp
+ v7m_cacheop \rt, \tmp, V7M_SCB_DCIMVAC, \c
.endm
+.endr
/*
* dccmvau: Clean data cache line by MVA to PoU
@@ -369,14 +371,16 @@ v7m_dma_inv_range:
tst r0, r3
bic r0, r0, r3
dccimvacne r0, r3
+ addne r0, r0, r2
subne r3, r2, #1 @ restore r3, corrupted by v7m's dccimvac
tst r1, r3
bic r1, r1, r3
dccimvacne r1, r3
-1:
- dcimvac r0, r3
- add r0, r0, r2
cmp r0, r1
+1:
+ dcimvaclo r0, r3
+ addlo r0, r0, r2
+ cmplo r0, r1
blo 1b
dsb st
ret lr
--
2.19.1
next prev parent reply other threads:[~2018-12-13 4:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-13 4:30 [PATCH AUTOSEL 4.14 01/41] mac80211_hwsim: fix module init error paths for netlink Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 02/41] Input: hyper-v - fix wakeup from suspend-to-idle Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 03/41] scsi: libiscsi: Fix NULL pointer dereference in iscsi_eh_session_reset Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 04/41] scsi: vmw_pscsi: Rearrange code to avoid multiple calls to free_irq during unload Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 05/41] x86/earlyprintk/efi: Fix infinite loop on some screen widths Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 06/41] drm/msm: Grab a vblank reference when waiting for commit_done Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 07/41] ARC: io.h: Implement reads{x}()/writes{x}() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 08/41] bonding: fix 802.3ad state sent to partner when unbinding slave Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 09/41] bpf: Fix verifier log string check for bad alignment Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 10/41] nfs: don't dirty kernel pages read by direct-io Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 11/41] SUNRPC: Fix leak of krb5p encode pages Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 12/41] SUNRPC: Fix a potential race in xprt_connect() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 13/41] sbus: char: add of_node_put() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 14/41] drivers/sbus/char: " Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 15/41] drivers/tty: add missing of_node_put() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 16/41] ide: pmac: add of_node_put() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 17/41] drm/msm: Fix error return checking Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 18/41] clk: mvebu: Off by one bugs in cp110_of_clk_get() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 19/41] clk: mmp: Off by one in mmp_clk_add() Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 20/41] Input: synaptics - enable SMBus for HP 15-ay000 Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 21/41] Input: omap-keypad - fix keyboard debounce configuration Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 22/41] libata: whitelist all SAMSUNG MZ7KM* solid-state disks Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 23/41] net: phy: don't allow __set_phy_supported to add unsupported modes Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 24/41] net: 8139cp: fix a BUG triggered by changing mtu with network traffic Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 25/41] net: phy: Fix not to call phy_resume() if PHY is not attached Sasha Levin
2018-12-13 4:49 ` Yoshihiro Shimoda
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 26/41] mv88e6060: disable hardware level MAC learning Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 27/41] net/mlx4_en: Change min MTU size to ETH_MIN_MTU Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 28/41] net/mlx4_en: Fix build break when CONFIG_INET is off Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 29/41] ARM: 8814/1: mm: improve/fix ARM v7_dma_inv_range() unaligned address handling Sasha Levin
2018-12-13 4:30 ` Sasha Levin [this message]
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 31/41] ethernet: fman: fix wrong of_node_put() in probe function Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 32/41] drm/ast: Fix connector leak during driver unload Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 33/41] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 34/41] vhost/vsock: fix reset orphans race with close timeout Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 35/41] mlxsw: spectrum_switchdev: Fix VLAN device deletion via ioctl Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 36/41] i2c: axxia: properly handle master timeout Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 37/41] i2c: scmi: Fix probe error on devices with an empty SMB0001 ACPI device node Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 38/41] i2c: uniphier: fix violation of tLOW requirement for Fast-mode Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 39/41] i2c: uniphier-f: " Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 40/41] nvmet-rdma: fix response use after free Sasha Levin
2018-12-13 4:30 ` [PATCH AUTOSEL 4.14 41/41] net/mlx4_core: Correctly set PFC param if global pause is turned off Sasha Levin
2018-12-13 9:15 ` [PATCH AUTOSEL 4.14 01/41] mac80211_hwsim: fix module init error paths for netlink Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213043054.75891-30-sashal@kernel.org \
--to=sashal@kernel.org \
--cc=chris@sageembedded.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+kernel@armlinux.org.uk \
--cc=stable@vger.kernel.org \
--cc=vladimir.murzin@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox