From: Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
To: Dmitry Safonov <dima@arista.com>
Cc: Waiman Long <longman@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Yang Shi <yang.shi@linux.alibaba.com>,
Arnd Bergmann <arnd@arndb.de>,
Sergey Senozhatsky <sergey.senozhatsky.work@gmail.com>
Subject: Re: [PATCH] debugobjects: Move printk out of db lock critical sections
Date: Thu, 13 Dec 2018 14:18:53 +0900 [thread overview]
Message-ID: <20181213051853.GG4860@jagdpanzerIV> (raw)
In-Reply-To: <9cb1526a-e82f-dfa7-4b3c-5ea911a8d476@arista.com>
On (12/13/18 04:35), Dmitry Safonov wrote:
> I've tried to review it and found minor issues like missed
> debug_object_is_on_stack() for initializing already active object.
>
> But than I come to opinion that it's just generally unsafe:
> debug_obj life-time is protected by bucket's spin_lock.
> Check the conditions when free_object() is being called.
I thought about it for a second, but couldn't figure out if this race
was real.
E.g. uart case - if there are two paths which concurrently free and
access debug object, then the same race condition should exist for
the xmit.buf page. debug object's lifespan should be the same as the
lifespan of, ummm, whatever the thing that debug object is attached
to? I'm surely missing something here.
-ss
next prev parent reply other threads:[~2018-12-13 5:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 22:28 [PATCH] debugobjects: Move printk out of db lock critical sections Waiman Long
2018-12-12 23:39 ` Andrew Morton
2018-12-13 22:01 ` Waiman Long
2018-12-13 2:03 ` Sergey Senozhatsky
2018-12-13 19:59 ` Waiman Long
2018-12-13 2:59 ` Sergey Senozhatsky
2018-12-13 9:21 ` Peter Zijlstra
2018-12-13 4:35 ` Dmitry Safonov
2018-12-13 5:18 ` Sergey Senozhatsky [this message]
2018-12-13 5:54 ` Dmitry Safonov
2018-12-13 9:00 ` Sergey Senozhatsky
2018-12-13 22:10 ` Waiman Long
2018-12-14 18:06 ` Dmitry Safonov
2018-12-14 18:21 ` Waiman Long
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213051853.GG4860@jagdpanzerIV \
--to=sergey.senozhatsky.work@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=dima@arista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longman@redhat.com \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=yang.shi@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox