Re: [PATCH v3 4/8] perf cs-etm: Refactor enumeration cs_etm_sample_type

Mathieu Poirier
2018-12-12T18:41:47Z

On Tue, Dec 11, 2018 at 03:38:24PM +0800, Leo Yan wrote:
> The values in enumeration cs_etm_sample_type are defined with setting
> bit N for each packet type, this is not suggested in the usual case.
>
> This patch refactor cs_etm_sample_type by converting from bit shifting
> values to continuous numbers.
>
> Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Mike Leach <mike.leach@linaro.org>
> Cc: Robert Walker <robert.walker@arm.com>
> ---
> tools/perf/util/cs-etm-decoder/cs-etm-decoder.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
> index b295dd2..3819a04 100644
> --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
> +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.h
> @@ -23,9 +23,9 @@ struct cs_etm_buffer {
> };
>
> enum cs_etm_sample_type {
> - CS_ETM_EMPTY = 0,
> - CS_ETM_RANGE = 1 << 0,
> - CS_ETM_TRACE_ON = 1 << 1,
> + CS_ETM_EMPTY,
> + CS_ETM_RANGE,
> + CS_ETM_TRACE_ON,
> };

Reviewed-by: Mathieu Poirier <mathieu.poirier@linaro.org>

>
> enum cs_etm_isa {
> --
> 2.7.4
>