From: Thierry Reding <thierry.reding@gmail.com>
To: Joe Perches <joe@perches.com>
Cc: "Jeremy Cline" <jcline@redhat.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Jonathan Corbet" <corbet@lwn.net>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode
Date: Thu, 13 Dec 2018 17:14:23 +0100 [thread overview]
Message-ID: <20181213161423.GB13531@ulmo> (raw)
In-Reply-To: <642dd9ea144c03041ad74b14777553fe652acd1a.camel@perches.com>
[-- Attachment #1: Type: text/plain, Size: 888 bytes --]
On Wed, Dec 12, 2018 at 06:51:19PM -0800, Joe Perches wrote:
> On Wed, 2018-12-12 at 13:14 -0500, Jeremy Cline wrote:
> > It might be worth noting this fixes commit 6f4d29df66ac
> > ("scripts/spdxcheck.py: make python3 compliant")
>
> umm, how does it do that?
>
> > and also Cc this for
> > stable since 6f4d29df66ac got backported to v4.19. While that commit
> > did indeed make the script work with Python 3 for piping data, it broke
> > Python 2 and made its way to stable.
>
> I think attempting to use spdxcheck on binary files
> is not useful in the first place.
Agreed. However, if run without arguments the tool will walk the entire
tree and inevitably run into binary files. I realize that this is kind
of a lame way of dealing with binary files, but the alternatives would
be much more complicated and involve dealing with mimetypes and such.
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-12-13 16:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 13:12 [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode Thierry Reding
2018-12-12 13:12 ` [PATCH 2/2] scripts: Add spdxcheck.py self test Thierry Reding
2018-12-12 18:14 ` [PATCH 1/2] scripts/spdxcheck.py: Always open files in binary mode Jeremy Cline
2018-12-13 2:51 ` Joe Perches
2018-12-13 16:14 ` Thierry Reding [this message]
2018-12-13 7:37 ` Uwe Kleine-König
2018-12-13 15:10 ` Jeremy Cline
2018-12-13 19:40 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181213161423.GB13531@ulmo \
--to=thierry.reding@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=jcline@redhat.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox