From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B1DC65BAE for ; Fri, 14 Dec 2018 00:44:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0621020892 for ; Fri, 14 Dec 2018 00:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544748242; bh=qiwmRejJtBcgQBbtzhZHQ2STHBHennZb7QnBQ4FdPAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=swWot91biYxgda41azVnlHsfY9Xuch3hOaKPIbWSAgyJSOE94dAc46ckUFP54Onbl e6GqxRwVhKCz/jSAwn14H5X9MDIaBfq2hhI6WVcDZjn/3aRbhg1Kuy5E0ckX0sEIxx WMJjM7pvaMmc6s2FSxViISIlUw1gsiMH67S4GeN4= DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0621020892 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728576AbeLNAoA (ORCPT ); Thu, 13 Dec 2018 19:44:00 -0500 Received: from mail.kernel.org ([198.145.29.99]:48876 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726254AbeLNAn7 (ORCPT ); Thu, 13 Dec 2018 19:43:59 -0500 Received: from dragon (61-216-91-114.HINET-IP.hinet.net [61.216.91.114]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 842B32075B; Fri, 14 Dec 2018 00:43:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1544748238; bh=qiwmRejJtBcgQBbtzhZHQ2STHBHennZb7QnBQ4FdPAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=zkym+oO6nQ5yVdejfiFlmhMiKwn/GYjaPLLLbbODWZ2NI2xCWtGyiRBPKKpjKBCDm A/Pl967Ghhjq5FStCcsbEarTeY44ynkKw04rhARwPBhuzECM5nwqykrj0WLK0GUvjA v6rRBHQrk7v8+cmT3f+05xU8eZcWZiA4NMSykMww= Date: Fri, 14 Dec 2018 08:42:57 +0800 From: Shawn Guo To: Schrempf Frieder Cc: Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , Sascha Hauer , "boris.brezillon@bootlin.com" , "broonie@kernel.org" , "linux-mtd@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "linux-spi@vger.kernel.org" Subject: Re: [PATCH 0/5] Prepare devicetrees for the new FSL QSPI driver Message-ID: <20181214004251.GA15775@dragon> References: <1544459182-23655-1-git-send-email-frieder.schrempf@kontron.de> <1ad93cdf-7ba1-ff49-f330-6bbd0f6c6972@kontron.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1ad93cdf-7ba1-ff49-f330-6bbd0f6c6972@kontron.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 13, 2018 at 09:45:04AM +0000, Schrempf Frieder wrote: > + Shawn, Sascha > > On 10.12.18 17:31, Schrempf Frieder wrote: > > Hi FSL/ARM maintainers, > > > > On 10.12.18 17:26, Schrempf Frieder wrote: > >> From: Frieder Schrempf > >> > >> We have prepared a new driver for the FSL QSPI controller that works under > >> the SPI framework. The current devicetrees are broken because they use an > >> inconsistent scheme for assigning the reg properties. > >> > >> As, in contrast to the current driver, the new driver will use the reg > >> properties to select the correct chip, we need to fix them. > >> > >> We also add spi-[tx/rx]-bus-width to make sure the full buswidth will be used > >> and while at it clean up and remove some unused properties. > > > > could you please consider these devicetree patches for v4.21? > > Any chance to get this merged? Otherwise we would need to postpone the > new driver even further. As it came up a little bit late (the same day I sent pull request for 4.21), I was considering it as 4.22 material. But as you mentioned that the series is non-intrusive, I can try to send it to arm-soc folk for 4.21 merge window, and then that will be their call. But before I do it, I need you to double confirm that the series will not break anything that is already working. Shawn > > All the changes to the devicetrees in this series are non-intrusive and > uncritical, anyway. > > Thanks, > Frieder > > > > > We have the new FSL QSPI driver under the SPI framework ([1]) ready, but > > we need some small fixes to the devicetrees that are currently broken. > > > > As the new driver depends on these changes (mainly the change to the reg > > properties) and it is not possible to add compatibility for the old > > bindings, it would be really nice to have them in v4.21, so we can queue > > the driver for v4.22 or whatever the next release will be called. > > > > Please also see [2] for some more explanation. > > > > Thanks, > > Frieder > > > > [1] https://patchwork.ozlabs.org/cover/1007641/ > > [2] https://patchwork.ozlabs.org/patch/922817/#1925445 > > > >> > >> Frieder Schrempf (5): > >> arm64: dts: Remove unused properties from FSL QSPI driver nodes > >> ARM: dts: Remove unused properties from FSL QSPI driver nodes > >> ARM: dts: imx6sx-sdb: Fix the reg properties for the FSL QSPI nodes > >> arm64: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller > >> ARM: dts: Add spi-[tx/rx]-bus-width for the FSL QSPI controller > >> > >> arch/arm/boot/dts/imx6sx-sdb-reva.dts | 8 ++++++-- > >> arch/arm/boot/dts/imx6sx-sdb.dts | 8 ++++++-- > >> arch/arm/boot/dts/imx6ul-14x14-evk.dtsi | 2 ++ > >> arch/arm/boot/dts/ls1021a-moxa-uc-8410a.dts | 5 ++--- > >> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dts | 3 ++- > >> arch/arm64/boot/dts/freescale/fsl-ls1046a-qds.dts | 4 ++-- > >> arch/arm64/boot/dts/freescale/fsl-ls1046a-rdb.dts | 6 ++++-- > >> arch/arm64/boot/dts/freescale/fsl-ls208xa-qds.dtsi | 4 ++++ > >> 8 files changed, 28 insertions(+), 12 deletions(-) > >> > > ______________________________________________________ > > Linux MTD discussion mailing list > > http://lists.infradead.org/mailman/listinfo/linux-mtd/ > >