From: Lee Jones <lee.jones@linaro.org>
To: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>
Cc: "J, KEERTHY" <j-keerthy@ti.com>,
linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe()
Date: Fri, 14 Dec 2018 12:26:19 +0000 [thread overview]
Message-ID: <20181214122619.GW4497@dell> (raw)
In-Reply-To: <20181214122559.GV4497@dell>
On Fri, 14 Dec 2018, Lee Jones wrote:
> On Thu, 06 Dec 2018, Christian Hohnstaedt wrote:
>
> > Free allocated IRQ if reading the device ID fails.
>
> The patch is fine. However, in future please submit patches using the
> format set (by precedent) by the subsystem. I will fix the subject
> for you this time.
>
> To check the format, you can do:
>
> `git log --oneline -- <subsystem>`
Patch applied, by the way.
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-14 12:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 9:57 [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe() Christian Hohnstaedt
2018-12-14 12:25 ` Lee Jones
2018-12-14 12:26 ` Lee Jones [this message]
2018-12-17 6:01 ` J, KEERTHY
2018-12-17 14:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214122619.GW4497@dell \
--to=lee.jones@linaro.org \
--cc=Christian.Hohnstaedt@wago.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox