From: Borislav Petkov <bp@alien8.de>
To: Thomas Schoebel-Theuer <tst@schoebel-theuer.de>
Cc: linux-kernel@vger.kernel.org, Laura Abbott <labbott@redhat.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH] acpi / apei: fix NULL deref during init
Date: Fri, 14 Dec 2018 21:24:06 +0100 [thread overview]
Message-ID: <20181214202406.GI11710@zn.tnic> (raw)
In-Reply-To: <20181214181514.29891-1-tst@schoebel-theuer.de>
On Fri, Dec 14, 2018 at 07:15:14PM +0100, Thomas Schoebel-Theuer wrote:
> Reason is a conditional initialization of variable arch_res, which happens
> only under a specific precondition. When the condition is false, the
> variable remains uninitialized.
Are you talking about the precondition
if (arch_apei_filter_addr)
?
Because apei_resources_fini() happens under the same condition check and
if arch_apei_filter_addr was false, it should not become true, all of a
sudden. Or?
Or does that function ptr get set in the meantime on your machine? I.e., this
hackery:
#define set_apei_filter() (arch_apei_filter_addr = pci_mmcfg_for_each_region)
being called in pci_mmcfg_early_init()...
?
Hmmm.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2018-12-14 20:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 18:15 [PATCH] acpi / apei: fix NULL deref during init Thomas Schoebel-Theuer
2018-12-14 18:43 ` Laura Abbott
2018-12-14 20:24 ` Borislav Petkov [this message]
2018-12-14 21:27 ` Thomas Schoebel-Theuer
2018-12-14 22:22 ` Borislav Petkov
2018-12-14 22:42 ` Thomas Schöbel-Theuer
2018-12-14 22:54 ` Borislav Petkov
2018-12-15 8:05 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181214202406.GI11710@zn.tnic \
--to=bp@alien8.de \
--cc=labbott@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=tony.luck@intel.com \
--cc=tst@schoebel-theuer.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox