From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DE45C43612 for ; Sat, 15 Dec 2018 00:06:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 71E9E20896 for ; Sat, 15 Dec 2018 00:06:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728548AbeLOAG3 (ORCPT ); Fri, 14 Dec 2018 19:06:29 -0500 Received: from mga11.intel.com ([192.55.52.93]:4820 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbeLOAG3 (ORCPT ); Fri, 14 Dec 2018 19:06:29 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Dec 2018 16:06:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,354,1539673200"; d="scan'208";a="118955556" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.154]) by orsmga001.jf.intel.com with ESMTP; 14 Dec 2018 16:06:27 -0800 Date: Fri, 14 Dec 2018 16:06:27 -0800 From: Sean Christopherson To: "Dr. Greg" Cc: Jarkko Sakkinen , Andy Lutomirski , Andy Lutomirski , X86 ML , Platform Driver , linux-sgx@vger.kernel.org, Dave Hansen , nhorman@redhat.com, npmccallum@redhat.com, "Ayoun, Serge" , shay.katz-zamir@intel.com, haitao.huang@linux.intel.com, Andy Shevchenko , Thomas Gleixner , "Svahn, Kai" , mark.shanahan@intel.com, Suresh Siddha , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Darren Hart , Andy Shevchenko , LKML , jethro@fortanix.com Subject: Re: [PATCH v17 18/23] platform/x86: Intel SGX driver Message-ID: <20181215000627.GA5799@linux.intel.com> References: <20181126215145.GC868@linux.intel.com> <20181126230436.GA6737@linux.intel.com> <20181127085533.GA12247@wind.enjellic.com> <20181127164129.GB4170@linux.intel.com> <20181128104941.GA23077@wind.enjellic.com> <20181128192228.GC9023@linux.intel.com> <20181210104908.GA23132@wind.enjellic.com> <20181212180036.GC6333@linux.intel.com> <20181214235917.GA14049@wind.enjellic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181214235917.GA14049@wind.enjellic.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 14, 2018 at 05:59:17PM -0600, Dr. Greg wrote: > On Wed, Dec 12, 2018 at 08:00:36PM +0200, Jarkko Sakkinen wrote: > > Good evening, I hope the week has gone well for everyone. > > > On Mon, Dec 10, 2018 at 04:49:08AM -0600, Dr. Greg wrote: > > > In the meantime, I wanted to confirm that your jarkko-sgx/master > > > branch contains the proposed driver that is headed upstream. > > > Before adding the SFLC patches we thought it best to run the > > > driver through some testing in order to verify that any problems > > > we generated where attributable to our work and not the base > > > driver. > > > > The master branch is by definition unstable at the moment i.e. it > > can sometimes (not often) contain unfinished changes. Use next for > > testing. I update next when I consider the master contents "stable > > enough". > > I noticed in the last day or so that you appeared to sync > jarkko-sgx/master with jarkko-sgx/next, so I checked out a local > branch against jarkko-sgx/next and ran it against our unit tests. > Based on what we are seeing the driver is still experiencing issues > with initialization of a non-trivial enclave. master branch is broken, looks like the VMA code Jarkko is reworking is buggy. I should be able to help debug this next week. [ 504.149548] ------------[ cut here ]------------ [ 504.149550] kernel BUG at /home/sean/go/src/kernel.org/linux/mm/mmap.c:669! [ 504.150288] invalid opcode: 0000 [#1] SMP [ 504.150614] CPU: 2 PID: 237 Comm: kworker/u20:2 Not tainted 4.20.0-rc2+ #267 [ 504.151165] Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 0.0.0 02/06/2015 [ 504.151818] Workqueue: sgx-encl-wq sgx_encl_release_worker [ 504.152267] RIP: 0010:__vma_adjust+0x64a/0x820 [ 504.152626] Code: ff 48 89 50 18 e9 6f fc ff ff 4c 8b ab 88 00 00 00 45 31 e4 e9 61 fb ff ff 31 c0 48 83 c4 60 5b 5d 41 5c 41 5d 41 5e 41 5f c3 <0f> 0b 49 89 de 49 83 c6 20 0f 84 06 fe ff ff 49 8d 7e e0 e8 fe ee [ 504.154109] RSP: 0000:ffffc900004ebd60 EFLAGS: 00010206 [ 504.154535] RAX: 00007fd92ef7e000 RBX: ffff888467af16c0 RCX: ffff888467af16e0 [ 504.155104] RDX: ffff888458fd09e0 RSI: 00007fd954021000 RDI: ffff88846bf9e798 [ 504.155673] RBP: ffff888467af1480 R08: ffff88845bea2000 R09: 0000000000000000 [ 504.156242] R10: 0000000080000000 R11: fefefefefefefeff R12: 0000000000000000 [ 504.156810] R13: ffff88846bf9e790 R14: ffff888467af1b70 R15: ffff888467af1b60 [ 504.157378] FS: 0000000000000000(0000) GS:ffff88846f700000(0000) knlGS:0000000000000000 [ 504.158021] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 504.158483] CR2: 00007f2c56e99000 CR3: 0000000005009001 CR4: 0000000000360ee0 [ 504.159054] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 [ 504.159623] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 [ 504.160193] Call Trace: [ 504.160406] __split_vma+0x16f/0x180 [ 504.160706] ? __switch_to_asm+0x40/0x70 [ 504.161024] __do_munmap+0xfb/0x450 [ 504.161308] sgx_encl_release_worker+0x44/0x70 [ 504.161675] process_one_work+0x200/0x3f0 [ 504.162004] worker_thread+0x2d/0x3d0 [ 504.162301] ? process_one_work+0x3f0/0x3f0 [ 504.162645] kthread+0x113/0x130 [ 504.162912] ? kthread_park+0x90/0x90 [ 504.163209] ret_from_fork+0x35/0x40 [ 504.163503] Modules linked in: bridge stp llc [ 504.163866] ---[ end trace 83076139fc25e3e0 ]---