public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Sergey Efimochkin <sergeyanton2007@gmail.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Sergey Efimochkin <efimochkin.sv@phystech.edu>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH] staging:iio:adc: fix codestyle
Date: Mon, 17 Dec 2018 10:45:41 +0300	[thread overview]
Message-ID: <20181217074540.GC15451@kadam> (raw)
In-Reply-To: <20181217014333.75969-1-efimochkin.sv@phystech.edu>

The patch prefix should be "staging: iio: adc: ad7280a:".  Do
git log --oneline drivers/staging/iio/adc/ad7280a.c and copy what
other people do.

On Mon, Dec 17, 2018 at 04:43:33AM +0300, Sergey Efimochkin wrote:
> staging:iio:adc: fix codestyle

Only to do one thing per patch.  We need a better patch description.

> Signed-off-by: Sergey Efimochkin <efimochkin.sv@phystech.edu>
> ---
>  drivers/staging/iio/adc/ad7280a.c | 20 +++++++++-----------
>  1 file changed, 9 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/iio/adc/ad7280a.c b/drivers/staging/iio/adc/ad7280a.c
> index 58420dcb406d..52e12d1201b3 100644
> --- a/drivers/staging/iio/adc/ad7280a.c
> +++ b/drivers/staging/iio/adc/ad7280a.c
> @@ -706,8 +706,8 @@ static irqreturn_t ad7280_event_handler(int irq, void *private)
>  				st->cell_threshhigh)
>  				iio_push_event(indio_dev,
>  					       IIO_EVENT_CODE(IIO_VOLTAGE,
> -							1,
> -							0,
> +							      1,
> +							      0,
>  							IIO_EV_DIR_RISING,
>  							IIO_EV_TYPE_THRESH,
>  							0, 0, 0),

No.  Now the IIO_EV_DIR_RISING, and later columns are not aligned
correctly.  Just ignore the checkpatch warning.  It's fine as-is.

> @@ -987,6 +985,6 @@ static struct spi_driver ad7280_driver = {
>  };
>  module_spi_driver(ad7280_driver);
>  
> -MODULE_AUTHOR("Michael Hennerich <michael.hennerich@analog.com>");
> +MODULE_AUTHOR("Michael Hennerich <hennerich@blackfin.uclinux.org>");

This change needs to come from Michael.  Just leave the code as-is.

regards,
dan carpenter


  reply	other threads:[~2018-12-17  7:46 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17  1:43 [PATCH] staging:iio:adc: fix codestyle Sergey Efimochkin
2018-12-17  7:45 ` Dan Carpenter [this message]
2018-12-17 22:06   ` [PATCH v2] staging: iio: adc: ad7280a: fix codestyle in ad7280_event_handler Sergey Efimochkin
2018-12-22 17:04     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217074540.GC15451@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=efimochkin.sv@phystech.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=sergeyanton2007@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox