public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: "J, KEERTHY" <j-keerthy@ti.com>
Cc: Christian Hohnstaedt <Christian.Hohnstaedt@wago.com>,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe()
Date: Mon, 17 Dec 2018 14:34:35 +0000	[thread overview]
Message-ID: <20181217143435.GC4497@dell> (raw)
In-Reply-To: <f584aab6-374c-5a53-51c5-61098f8bb792@ti.com>

On Mon, 17 Dec 2018, J, KEERTHY wrote:

> 
> 
> On 12/14/2018 5:56 PM, Lee Jones wrote:
> > On Fri, 14 Dec 2018, Lee Jones wrote:
> > 
> > > On Thu, 06 Dec 2018, Christian Hohnstaedt wrote:
> > > 
> > > > Free allocated IRQ if reading the device ID fails.
> > > 
> > > The patch is fine.  However, in future please submit patches using the
> > > format set (by precedent) by the subsystem.  I will fix the subject
> > > for you this time.
> > > 
> > > To check the format, you can do:
> > > 
> > >    `git log --oneline -- <subsystem>`
> > 
> > Patch applied, by the way.
> 
> This would no longer be needed as the bigger clean up is here:
> 
> https://lkml.org/lkml/2018/12/9/86
> 
> As both are applied it results in a compilation issue.
> 
> Lee Jones,
> 
> Do you want me to submit a fix patch? Or you can revert this patch?
> Anything fine by me.

I have removed this patch from the MFD tree now.  Thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

      reply	other threads:[~2018-12-17 14:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-06  9:57 [PATCH] tps65218.c: fix IRQ resource leak in tps65218_probe() Christian Hohnstaedt
2018-12-14 12:25 ` Lee Jones
2018-12-14 12:26   ` Lee Jones
2018-12-17  6:01     ` J, KEERTHY
2018-12-17 14:34       ` Lee Jones [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181217143435.GC4497@dell \
    --to=lee.jones@linaro.org \
    --cc=Christian.Hohnstaedt@wago.com \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox