Re: [PATCH v11 1/7] ACPI: Allow CONFIG_PCI to be unset for reboot

Christoph Hellwig
2018-12-18T07:31:42Z

> +#ifdef CONFIG_PCI
> + unsigned int devfn;
> + struct pci_bus *bus0;
> +
> /* The reset register can only live on bus 0. */
> bus0 = pci_find_bus(0, 0);
> if (!bus0)
> @@ -44,8 +47,9 @@ void acpi_reboot(void)
> /* Write the value that resets us. */
> pci_bus_write_config_byte(bus0, devfn,
> (rr->address & 0xffff), reset_value);
> +#endif

This would be a lot cleaner if this was split into a little helper
function.