From: Lee Jones <lee.jones@linaro.org>
To: Cheng-yi Chiang <cychiang@chromium.org>
Cc: bleung@chromium.org, groeck@chromium.org,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, Dylan Reid <dgreid@chromium.org>,
tzungbi@chromium.org, Rohit kumar <rohitkr@codeaurora.org>,
scollyer@chromium.org
Subject: Re: [PATCH v2] mfd: cros_ec: Add commands to control codec
Date: Tue, 18 Dec 2018 08:52:34 +0000 [thread overview]
Message-ID: <20181218084307.GH4497@dell> (raw)
In-Reply-To: <CAFv8Nw+RbzKrjE1tsgxdRntXKWp9XVq8hbP7MZ3mZ=a2rMyG2Q@mail.gmail.com>
On Tue, 18 Dec 2018, Cheng-yi Chiang wrote:
> +Benson, Guenter, Scott
>
> On Fri, Dec 14, 2018 at 8:22 PM Lee Jones <lee.jones@linaro.org> wrote:
> >
> > On Fri, 14 Dec 2018, Lee Jones wrote:
> >
> > > On Thu, 06 Dec 2018, Cheng-Yi Chiang wrote:
> > >
> > > > Add EC host commands to control codec on EC.
> > > >
> > > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> > > > ---
> > > > V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree.
> > > > Codec driver that uses these commands will be sent separately.
> > > > Thanks!
> > > >
> > > > include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
> > > > 1 file changed, 94 insertions(+)
> > >
> > > Would be good to have this reviewed by some more Chrome people.
> >
> > See this for reference:
> >
> > https://lore.kernel.org/patchwork/patch/1024985/
>
> Hi Benson and Guenter,
> Could you please review this patch ?
You haven't sent them the patch.
Please resubmit as a [RESEND] and add them as recipients.
> The corresponding implementation at EC side by Scott is at
> https://chromium-review.googlesource.com/c/chromiumos/platform/ec/+/1356185
>
> Thanks a lot!
>
> >
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-12-18 8:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-06 4:05 [PATCH v2] mfd: cros_ec: Add commands to control codec Cheng-Yi Chiang
2018-12-14 12:21 ` Lee Jones
2018-12-14 12:22 ` Lee Jones
2018-12-18 8:37 ` Cheng-yi Chiang
2018-12-18 8:52 ` Lee Jones [this message]
2018-12-22 19:47 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181218084307.GH4497@dell \
--to=lee.jones@linaro.org \
--cc=alsa-devel@alsa-project.org \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=dgreid@chromium.org \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=scollyer@chromium.org \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox