Re: [PATCH v4 2/2] trace nvme submit queue status

Christoph Hellwig
2018-12-18T17:03:17Z

On Mon, Dec 17, 2018 at 11:44:51PM -0800, peng yu wrote:
> Sorry, I don't quite understand your meaning. Do you mean I'd better
> change this:
> trace_nvme_sq(req->rq_disk,
> nvmeq->qid,
> le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> to something like below:
> trace_nvme_sq(req->rq_disk, nvmeq->qid, le16_to_cpu(cqe->sq_head),
> nvmeq->sq_tail);
> Please let me know whether my understanding is correct.

Yes. Let me know if this version that I've applied is fine with you: