Re: [PATCH v4 2/2] trace nvme submit queue status

Sagi Grimberg
2018-12-18T07:26:31Z

> @@ -899,6 +900,10 @@ static inline void nvme_handle_cqe(struct nvme_queue *nvmeq, u16 idx)
> }
>
> req = blk_mq_tag_to_rq(*nvmeq->tags, cqe->command_id);
> + trace_nvme_sq(req->rq_disk,
> + nvmeq->qid,
> + le16_to_cpu(cqe->sq_head),
> + nvmeq->sq_tail);

Why the newline escapes? why not escape at the 80 char border?

Other than that, looks fine,

Reviewed-by: Sagi Grimberg <sagi@grimberg.me>