From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 726F3C43387 for ; Tue, 18 Dec 2018 21:53:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A6572184C for ; Tue, 18 Dec 2018 21:53:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727351AbeLRVxQ (ORCPT ); Tue, 18 Dec 2018 16:53:16 -0500 Received: from muru.com ([72.249.23.125]:58726 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726614AbeLRVxQ (ORCPT ); Tue, 18 Dec 2018 16:53:16 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 1FA81810D; Tue, 18 Dec 2018 21:53:18 +0000 (UTC) Date: Tue, 18 Dec 2018 13:53:11 -0800 From: Tony Lindgren To: Pavel Machek Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Jarkko Nikula , Johan Hovold , Kuninori Morimoto , Marcel Partap , Merlijn Wajer , Michael Scott , NeKit , omerlle@gmail.com, Sebastian Reichel , Peter Ujfalusi , Rob Herring Subject: Re: WIP Droid 4 voice calls, GNSS & PM with a TS 27.010 serdev driver Message-ID: <20181218215311.GD6707@atomide.com> References: <20181217004450.GW6707@atomide.com> <20181218124616.GA10758@amd> <20181218153650.GA6707@atomide.com> <20181218202242.GA30831@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181218202242.GA30831@amd> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek [181218 20:22]: > Hi! > > > > # commit 0c1bc81ba976bcd480d6e3c3009a28589f8427c0 (patch) > > > # mfd: motmdm: Add Motorola TS 27.010 serdev driver for devices like droid4 > > > > > > Oh, that is a lot of fun. Especially state machine for parsing modem > > > responses. I wonder how well it is going to work when modem is > > > accessed over USB... > > > > > > motmdm_read_state(... size_t len) > > > > That's a bit of a layering violation yeah :) But we still need to > > do that somewhere for notifiers. And the notifications are separate > > from the commands and start with a ~ character so from that point of > > view it should not be too bad. > > Plus, you seem to assume that data will always come in suitably sized > chunks. Aha, and as it is not plain serial but packet protocol over > serial... I guess that is going to work? Yeah it's just packet data out of the n_gsm. > > > I did a quick test in my config... and it did not break my old setup > > > -- voice calls still work when set up over USB and with manual mixer > > > setup. That was good surprise. > > > > OK good to hear. Using the n_gsm port instead of USB during idle > > has a major PM advantage as the SoC can hit retention during idle > > while still connected to the modem and getting notifications. > > > > So looks like during idle we can keep USB in autosuspend mode with > > something like the below shell script function. > > Yes, I should really start using serials instead of USB. But... I have > working ofono there, and was using that phone and am little short on > time at the moment. Hopefully adding support to ofono and modemmanager to use use /dev/motmdm1 for calls should be quite trivial now. Regards, Tony