From: Buland Singh <bsingh@redhat.com>
To: clemens@ladisch.de
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, trivial@kernel.org,
prarit@redhat.com, bsingh@redhat.com
Subject: [PATCH] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable.
Date: Wed, 19 Dec 2018 14:55:02 +0530 [thread overview]
Message-ID: <20181219092502.3079-1-bsingh@redhat.com> (raw)
The kernel command parameter 'hpet_mmap' never takes effect due to missing
'=' character in the __setup() code of hpet_mmap_enable and the memory map
of the HPET registers never get expose to userspace.
Signed-off-by: Buland Singh <bsingh@redhat.com>
---
drivers/char/hpet.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/hpet.c b/drivers/char/hpet.c
index 4a22b4b41aef..9bffcd37cc7b 100644
--- a/drivers/char/hpet.c
+++ b/drivers/char/hpet.c
@@ -377,7 +377,7 @@ static __init int hpet_mmap_enable(char *str)
pr_info("HPET mmap %s\n", hpet_mmap_enabled ? "enabled" : "disabled");
return 1;
}
-__setup("hpet_mmap", hpet_mmap_enable);
+__setup("hpet_mmap=", hpet_mmap_enable);
static int hpet_mmap(struct file *file, struct vm_area_struct *vma)
{
--
2.19.1
next reply other threads:[~2018-12-19 9:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-19 9:25 Buland Singh [this message]
2018-12-19 9:46 ` [PATCH] hpet: Fix missing '=' character in the __setup() code of hpet_mmap_enable Greg KH
2018-12-19 12:04 ` Buland Singh
2018-12-19 12:37 ` Greg KH
2018-12-20 6:37 ` Buland Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219092502.3079-1-bsingh@redhat.com \
--to=bsingh@redhat.com \
--cc=arnd@arndb.de \
--cc=clemens@ladisch.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prarit@redhat.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox