From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8766C43387 for ; Wed, 19 Dec 2018 17:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91391218D3 for ; Wed, 19 Dec 2018 17:18:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730357AbeLSRSV (ORCPT ); Wed, 19 Dec 2018 12:18:21 -0500 Received: from muru.com ([72.249.23.125]:58790 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726555AbeLSRSV (ORCPT ); Wed, 19 Dec 2018 12:18:21 -0500 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 84E3D80CD; Wed, 19 Dec 2018 17:18:23 +0000 (UTC) Date: Wed, 19 Dec 2018 09:18:16 -0800 From: Tony Lindgren To: Mark Brown Cc: David Lechner , Roger Quadros , ohad@wizery.com, bjorn.andersson@linaro.org, robh+dt@kernel.org, bcousson@baylibre.com, ssantosh@kernel.org, s-anna@ti.com, nsekhar@ti.com, t-kristo@ti.com, nsaulnier@ti.com, jreeder@ti.com, m-karicheri2@ti.com, woods.technical@gmail.com, linux-omap@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 05/16] remoteproc/pru: Add pru-specific debugfs support Message-ID: <20181219171816.GE6707@atomide.com> References: <1543218769-5507-1-git-send-email-rogerq@ti.com> <1543218769-5507-6-git-send-email-rogerq@ti.com> <5BFFBCAC.9000004@ti.com> <5C191770.9090804@ti.com> <20181219123812.GC8130@sirena.org.uk> <5C1A670E.9020904@ti.com> <6ebcd7a6-6c85-0312-0651-fb4fbfc25e55@lechnology.com> <20181219170725.GH8130@sirena.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181219170725.GH8130@sirena.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mark Brown [181219 17:07]: > On Wed, Dec 19, 2018 at 04:48:52PM +0100, David Lechner wrote: > > On 12/19/18 4:43 PM, Roger Quadros wrote: > > > > Did I do something wrong or we just need to enhance regmap_debugfs.c? > > > Do you assign the name field in pru_regmap_config and > > pru_debug_regmap_config? > > Yeah, you'll at least need to override the name since the default is to > use the name of the device and that'll result in two duplicates. Also combining IO regions often has a serious issue that the separate IO regions may not be in the same device (or same interconnect target module). This means that flushing a posted write with a read-back for an IO region will only flush it for a single device and not the other(s). And this leads into hard to find bugs :) Regards, Tony