From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80229C43387 for ; Thu, 20 Dec 2018 09:39:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4CEF520811 for ; Thu, 20 Dec 2018 09:39:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298769; bh=fQPHQM0II3rlqOGufZd/oRoIxlZ+cKvrfZgTRYTQsk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=i4hIfb0bRHr/8IOgEzbPE7vX9QYDZXfbEELgmKEMZlAsx219afkKCP8E4DlWmxZwf 3s94MZtWjvHyGxYYWZekZPfGxpu+hSWjC+/uTkO9GkirgHu4IL0rbImA7Y05u7ViFj E//yFGJ9WlTQ8AGMu6dIapUuU+FSYN+dolxvE18M= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731553AbeLTJZf (ORCPT ); Thu, 20 Dec 2018 04:25:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:45368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731047AbeLTJZ3 (ORCPT ); Thu, 20 Dec 2018 04:25:29 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 202E721852; Thu, 20 Dec 2018 09:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545297928; bh=fQPHQM0II3rlqOGufZd/oRoIxlZ+cKvrfZgTRYTQsk8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rqTdxWYP4FalclFsnXsAuFQabBUXgC1A+F8xcvCLdn23QaVb4JYORPpspuQM37SJw 9yLLOHSOuDqcKZpOp8hreeuHFzHQZkdxi/jJNUcaOmsh+Tov1jFd19T//e0CiYWOlj jBONbA8ATsT1rT352iPvfS6bRGFFnwZs5hfkDYUI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Steve French , Pavel Shilovsky , Sasha Levin Subject: [PATCH 4.9 55/61] cifs: In Kconfig CONFIG_CIFS_POSIX needs depends on legacy (insecure cifs) Date: Thu, 20 Dec 2018 10:18:55 +0100 Message-Id: <20181220085845.983601854@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085843.743900603@linuxfoundation.org> References: <20181220085843.743900603@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 6e785302dad32228819d8066e5376acd15d0e6ba ] Missing a dependency. Shouldn't show cifs posix extensions in Kconfig if CONFIG_CIFS_ALLOW_INSECURE_DIALECTS (ie SMB1 protocol) is disabled. Signed-off-by: Steve French Reviewed-by: Pavel Shilovsky Signed-off-by: Sasha Levin --- fs/cifs/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifs/Kconfig b/fs/cifs/Kconfig index e7b478b49985..8bef27b8f85d 100644 --- a/fs/cifs/Kconfig +++ b/fs/cifs/Kconfig @@ -111,7 +111,7 @@ config CIFS_XATTR config CIFS_POSIX bool "CIFS POSIX Extensions" - depends on CIFS_XATTR + depends on CIFS && CIFS_ALLOW_INSECURE_LEGACY && CIFS_XATTR help Enabling this option will cause the cifs client to attempt to negotiate a newer dialect with servers, such as Samba 3.0.5 -- 2.19.1