From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BB36C43387 for ; Thu, 20 Dec 2018 09:39:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3BB4F20811 for ; Thu, 20 Dec 2018 09:39:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298754; bh=cJvaq2rL3bhE6sADqOOvHcOoflOr26MYD7lXf/BTG38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tgDCioNAIEu9Yf/NAfGGt/M8Tcc6ODcA0mrio+tFNg382jXkcP9E+sSjHTcyGleZI YSXZujuvYuuj5EitwtiaNjPi+EAhB7R8n/R2G+/et6nik/37UVfA/W3WonPTbhdW3G PTlE0im9fVlFMwmnqE70Zdo/GttzIfM6fktsYUGs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387461AbeLTJjN (ORCPT ); Thu, 20 Dec 2018 04:39:13 -0500 Received: from mail.kernel.org ([198.145.29.99]:47556 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731971AbeLTJZm (ORCPT ); Thu, 20 Dec 2018 04:25:42 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8EC99218D9; Thu, 20 Dec 2018 09:25:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545297942; bh=cJvaq2rL3bhE6sADqOOvHcOoflOr26MYD7lXf/BTG38=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=QSuPxlVrs0lMTS4UkG48zURIGG3jFdbNHL0+rdsZ8dl0M/7g4dr3kFe9obIlFEfrO gjoMHwGu3uFzP4ubFSdBo5hzD3ur/l8/D0CtWP/+1L1MbphK9I92Zd30vdrTDQLI9B HX6IajtEwN7reJ2Bqf4sU6zYXucf6J7itgaGdoek= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Steven Rostedt (VMware)" Subject: [PATCH 4.14 13/72] tracing: Fix memory leak of instance function hash filters Date: Thu, 20 Dec 2018 10:18:12 +0100 Message-Id: <20181220085922.856004182@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085922.332225035@linuxfoundation.org> References: <20181220085922.332225035@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Steven Rostedt (VMware) commit 2840f84f74035e5a535959d5f17269c69fa6edc5 upstream. The following commands will cause a memory leak: # cd /sys/kernel/tracing # mkdir instances/foo # echo schedule > instance/foo/set_ftrace_filter # rmdir instances/foo The reason is that the hashes that hold the filters to set_ftrace_filter and set_ftrace_notrace are not freed if they contain any data on the instance and the instance is removed. Found by kmemleak detector. Cc: stable@vger.kernel.org Fixes: 591dffdade9f ("ftrace: Allow for function tracing instance to filter functions") Signed-off-by: Steven Rostedt (VMware) Signed-off-by: Greg Kroah-Hartman --- kernel/trace/ftrace.c | 1 + 1 file changed, 1 insertion(+) --- a/kernel/trace/ftrace.c +++ b/kernel/trace/ftrace.c @@ -5534,6 +5534,7 @@ void ftrace_destroy_filter_files(struct if (ops->flags & FTRACE_OPS_FL_ENABLED) ftrace_shutdown(ops, 0); ops->flags |= FTRACE_OPS_FL_DELETED; + ftrace_free_filter(ops); mutex_unlock(&ftrace_lock); }