From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C9D9C43612 for ; Thu, 20 Dec 2018 09:28:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 473B521741 for ; Thu, 20 Dec 2018 09:28:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298084; bh=OmjYYVE3Yl3tgoTS4U0MWNb1cUvbFmDGUnASM8Hhls4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u5LGvLkAoUW/oPBS44aEVPQPQYSMRS4L6i7RqL/iNelMI+aTuy0CyTN2cwO4/nf70 03tuOGn2hexvpOn5WmVFA6Vp8EeKDbczp80uTguO68zzR8RSXzMEbkttAv7cjw5v2l 1373aCUdqs7R7z2+EKchn8t+O7W9gKgbWGwS/8DA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732419AbeLTJ2D (ORCPT ); Thu, 20 Dec 2018 04:28:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:41924 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732400AbeLTJ17 (ORCPT ); Thu, 20 Dec 2018 04:27:59 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B61D420656; Thu, 20 Dec 2018 09:27:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545298078; bh=OmjYYVE3Yl3tgoTS4U0MWNb1cUvbFmDGUnASM8Hhls4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=U7GcvcfOVKOrAVZt/Rl/dahDKpjLr9HtSw8Nth2MWE6UjGkIk0IUZnurumQHZnSlF QORlm+4LAs9KCkjNA6lW8kWsYqdIH6UfI7o/o3JHSEUFQ01F75lxuR/h6oPImJebkA JqWhhwqW9hKHlf9F6ltQWOF5ErVRvEwxrXwAHeIw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sam Bobroff , Daniel Vetter , Dave Airlie , Sasha Levin Subject: [PATCH 4.14 62/72] drm/ast: Fix connector leak during driver unload Date: Thu, 20 Dec 2018 10:19:01 +0100 Message-Id: <20181220085924.774773586@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085922.332225035@linuxfoundation.org> References: <20181220085922.332225035@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit e594a5e349ddbfdaca1951bb3f8d72f3f1660d73 ] When unloading the ast driver, a warning message is printed by drm_mode_config_cleanup() because a reference is still held to one of the drm_connector structs. Correct this by calling drm_crtc_force_disable_all() in ast_fbdev_destroy(). Signed-off-by: Sam Bobroff Reviewed-by: Daniel Vetter Signed-off-by: Dave Airlie Link: https://patchwork.freedesktop.org/patch/msgid/1e613f3c630c7bbc72e04a44b178259b9164d2f6.1543798395.git.sbobroff@linux.ibm.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/ast/ast_fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/ast/ast_fb.c b/drivers/gpu/drm/ast/ast_fb.c index 0cd827e11fa2..de26df0c6044 100644 --- a/drivers/gpu/drm/ast/ast_fb.c +++ b/drivers/gpu/drm/ast/ast_fb.c @@ -263,6 +263,7 @@ static void ast_fbdev_destroy(struct drm_device *dev, { struct ast_framebuffer *afb = &afbdev->afb; + drm_crtc_force_disable_all(dev); drm_fb_helper_unregister_fbi(&afbdev->helper); if (afb->obj) { -- 2.19.1